You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/05/06 14:46:36 UTC
Review Request 21110: Externalize OS family relationship
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21110/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-5671
https://issues.apache.org/jira/browse/AMBARI-5671
Repository: ambari
Description
-------
* Externalize the os family relationship.
* Fixed agent to return the specific os type (it was reporting the family as the type) and let the server resolve the family.
* This patch does NOT provide the UI the relationship (future).
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Facter.py 1d16604
ambari-agent/src/test/python/ambari_agent/TestHardware.py 64d0d12
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f8847d9
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 5c458a4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java bdce8a7
ambari-server/src/main/resources/os_family.json PRE-CREATION
Diff: https://reviews.apache.org/r/21110/diff/
Testing
-------
Agent
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.892s
[INFO] Finished at: Tue May 06 08:46:18 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------
Server
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:57.819s
[INFO] Finished at: Tue May 06 08:05:12 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 21110: Externalize OS family relationship
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21110/#review42531
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On May 7, 2014, 5:03 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21110/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 5:03 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-5671
> https://issues.apache.org/jira/browse/AMBARI-5671
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Externalize the os family relationship.
> * Fixed agent to return the specific os type (it was reporting the family as the type) and let the server resolve the family.
> * This patch does NOT provide the UI the relationship (future).
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Facter.py 1d16604
> ambari-agent/src/test/python/ambari_agent/TestHardware.py 64d0d12
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f8847d9
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 5c458a4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java bdce8a7
> ambari-server/src/main/resources/os_family.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21110/diff/
>
>
> Testing
> -------
>
> Agent
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 7.892s
> [INFO] Finished at: Tue May 06 08:46:18 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
>
> Server
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:57.819s
> [INFO] Finished at: Tue May 06 08:05:12 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
> Additional tests not required for OsFamily due to previously exercised code.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 21110: Externalize OS family relationship
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21110/#review42529
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On May 7, 2014, 5:03 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21110/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 5:03 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-5671
> https://issues.apache.org/jira/browse/AMBARI-5671
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Externalize the os family relationship.
> * Fixed agent to return the specific os type (it was reporting the family as the type) and let the server resolve the family.
> * This patch does NOT provide the UI the relationship (future).
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Facter.py 1d16604
> ambari-agent/src/test/python/ambari_agent/TestHardware.py 64d0d12
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f8847d9
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 5c458a4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java bdce8a7
> ambari-server/src/main/resources/os_family.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21110/diff/
>
>
> Testing
> -------
>
> Agent
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 7.892s
> [INFO] Finished at: Tue May 06 08:46:18 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
>
> Server
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:57.819s
> [INFO] Finished at: Tue May 06 08:05:12 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
> Additional tests not required for OsFamily due to previously exercised code.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 21110: Externalize OS family relationship
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21110/
-----------------------------------------------------------
(Updated May 7, 2014, 1:03 p.m.)
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
Changes
-------
typo
Bugs: AMBARI-5671
https://issues.apache.org/jira/browse/AMBARI-5671
Repository: ambari
Description
-------
* Externalize the os family relationship.
* Fixed agent to return the specific os type (it was reporting the family as the type) and let the server resolve the family.
* This patch does NOT provide the UI the relationship (future).
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Facter.py 1d16604
ambari-agent/src/test/python/ambari_agent/TestHardware.py 64d0d12
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f8847d9
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 5c458a4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java bdce8a7
ambari-server/src/main/resources/os_family.json PRE-CREATION
Diff: https://reviews.apache.org/r/21110/diff/
Testing (updated)
-------
Agent
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.892s
[INFO] Finished at: Tue May 06 08:46:18 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------
Server
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:57.819s
[INFO] Finished at: Tue May 06 08:05:12 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Additional tests not required for OsFamily due to previously exercised code.
Thanks,
Nate Cole
Re: Review Request 21110: Externalize OS family relationship
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21110/
-----------------------------------------------------------
(Updated May 7, 2014, 1:03 p.m.)
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-5671
https://issues.apache.org/jira/browse/AMBARI-5671
Repository: ambari
Description
-------
* Externalize the os family relationship.
* Fixed agent to return the specific os type (it was reporting the family as the type) and let the server resolve the family.
* This patch does NOT provide the UI the relationship (future).
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Facter.py 1d16604
ambari-agent/src/test/python/ambari_agent/TestHardware.py 64d0d12
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f8847d9
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 5c458a4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java bdce8a7
ambari-server/src/main/resources/os_family.json PRE-CREATION
Diff: https://reviews.apache.org/r/21110/diff/
Testing (updated)
-------
Agent
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.892s
[INFO] Finished at: Tue May 06 08:46:18 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------
Server
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:57.819s
[INFO] Finished at: Tue May 06 08:05:12 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Additional request not required for OsFamily due to previously exercised code.
Thanks,
Nate Cole