You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:57:47 UTC

[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6515: Generalize the use of booleans to support all cmake boolean values.

rkimball commented on a change in pull request #6515:
URL: https://github.com/apache/incubator-tvm/pull/6515#discussion_r492172680



##########
File path: cmake/util/FindCUDA.cmake
##########
@@ -37,7 +37,7 @@
 #
 macro(find_cuda use_cuda)
   set(__use_cuda ${use_cuda})
-  if(__use_cuda STREQUAL "ON")
+  if(${__use_cuda})

Review comment:
       This case does not need any special treatment, it is checking if __use_cuda is a boolean true value. If __use_cuda is a string (path) then this test will fail and the test on line 42 below is checked.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org