[jira] [Commented] (AIRFLOW-4800) GKE operators call GKEClusterHook with wrong (old) arguments

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865204#comment-16865204 ] 

ASF GitHub Bot commented on AIRFLOW-4800:
-----------------------------------------

ryan-williams commented on pull request #5424: [AIRFLOW-4800] fix GKEClusterHook ctor calls
URL: https://github.com/apache/airflow/pull/5424
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4800
   
   ### Description
   #4364 changed the arguments to `GKEClusterCreateOperator` but didn't update some call-sites; this fixes those call-sites.
   
   ### Tests
   Existing tests are updated to expect correct arguments. Not sure if there's a better way to test this.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> GKE operators call GKEClusterHook with wrong (old) arguments
> ------------------------------------------------------------
>
>                 Key: AIRFLOW-4800
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4800
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib
>    Affects Versions: 1.10.3
>            Reporter: Ryan Williams
>            Assignee: Ryan Williams
>            Priority: Minor
>
> [#4364|https://github.com/apache/airflow/pull/4364/files#diff-6c81e7d223790753a57708ed860b51d1R39] changed GKEClusterHook's ctor arguments, but not call-sites in [GKEClusterDeleteOperator|https://github.com/apache/airflow/blob/2d18f0738f775183b06d19f0b6703285c8bdcb32/airflow/contrib/operators/gcp_container_operator.py#L89] and [GKEClusterCreateOperator|https://github.com/apache/airflow/blob/2d18f0738f775183b06d19f0b6703285c8bdcb32/airflow/contrib/operators/gcp_container_operator.py#L176].
> [Relevant tests|https://github.com/apache/airflow/blob/2d18f0738f775183b06d19f0b6703285c8bdcb32/tests/contrib/operators/test_gcp_container_operator.py#L57-L58] still assert that the old arguments are passed.
> I'd have thought that the {{location}} arg being passed to {{delegate_to}} would cause real usages of the GKE operators to break, but perhaps it doesn't and they are working. I'm not sure what real-world use of these operators is like.
> I think the fix is trivial and will PR it shortly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)