You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sk...@apache.org on 2022/12/13 15:42:57 UTC
[ignite-3] branch main updated: IGNITE-18371 Removed outdated TODOs
This is an automated email from the ASF dual-hosted git repository.
sk0x50 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 652f575537 IGNITE-18371 Removed outdated TODOs
652f575537 is described below
commit 652f575537bf3d310aadf0250bb68a6954d5cf72
Author: Slava Koptilin <sl...@gmail.com>
AuthorDate: Tue Dec 13 17:42:41 2022 +0200
IGNITE-18371 Removed outdated TODOs
---
.../org/apache/ignite/internal/table/distributed/TableManager.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java b/modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
index b35f7120a0..691674520c 100644
--- a/modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
+++ b/modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
@@ -685,9 +685,6 @@ public class TableManager extends Producer<TableEvent, TableEventParameters> imp
return failedFuture(e);
}
- // TODO: IGNITE-15554 Add logic for assignment recalculation in case of partitions or replicas changes
- // TODO: Until IGNITE-15554 is implemented it's safe to iterate over partitions and replicas cause there will
- // TODO: be exact same amount of partitions and replicas for both old and new assignments
for (int i = 0; i < partitions; i++) {
int partId = i;
@@ -722,7 +719,7 @@ public class TableManager extends Producer<TableEvent, TableEventParameters> imp
// If Raft is running in in-memory mode or the PDS has been cleared, we need to remove the current node
// from the Raft group in order to avoid the double vote problem.
- // See https://issues.apache.org/jira/browse/IGNITE-16668 for details.
+ // <MUTED> See https://issues.apache.org/jira/browse/IGNITE-16668 for details.
if (internalTbl.storage().isVolatile() || !hasData) {
fut = queryDataNodesCount(tblId, partId, newConfiguration.peers()).thenApply(dataNodesCount -> {
boolean fullPartitionRestart = dataNodesCount == 0;