You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by sumitchawla <gi...@git.apache.org> on 2016/09/27 02:46:46 UTC
[GitHub] incubator-beam pull request #1013: BEAM-682-Invoker Class should be created ...
GitHub user sumitchawla opened a pull request:
https://github.com/apache/incubator-beam/pull/1013
BEAM-682-Invoker Class should be created in Thread Context Classloader
As of now the InvokerClass is being loaded in wrong classloader. It should be loaded into Thread.currentThread.getContextClassLoader()
https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokers.java#L167
Class<? extends DoFnInvoker<?, ?>> res =
(Class<? extends DoFnInvoker<?, ?>>)
unloaded
.load(DoFnInvokers.class.getClassLoader(), ClassLoadingStrategy.Default.INJECTION)
.getLoaded();
Fix
Class<? extends DoFnInvoker<?, ?>> res =
(Class<? extends DoFnInvoker<?, ?>>)
unloaded
.load(Thread.currentThread().getContextClassLoader(),
ClassLoadingStrategy.Default.INJECTION)
.getLoaded();
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sumitchawla/incubator-beam classloader_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1013.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1013
----
commit ecb7fc6c7ec7b0a2016f7da5edf9cf7f3bc9ace4
Author: Sumit Chawla <su...@cisco.com>
Date: 2016-09-27T02:45:22Z
BEAM-682-Invoker Class should be created in Thread Context Classloader
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1013: BEAM-682-Invoker Class should be created ...
Posted by sumitchawla <gi...@git.apache.org>.
Github user sumitchawla closed the pull request at:
https://github.com/apache/incubator-beam/pull/1013
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---