You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/12 02:12:15 UTC

[GitHub] [hudi] manojpec opened a new pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

manojpec opened a new pull request #3978:
URL: https://github.com/apache/hudi/pull/3978


   ## What is the purpose of the pull request
   With rollback after first commit support added to metadata table, these test cases are safe to have metadata table turned on.
   
   ## Brief change log
   
   Turning on metadata table for TestHoodieIndex#testSimpleTagLocationAndUpdateWithRollback and 
    TestMergeOnReadRollbackActionExecutor#testRollbackWhenFirstCommitFail
   
   
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966783881


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3322",
       "triggerID" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f1f147b44eb287ba95d31f98609da975705b94e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3322) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966765464


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3322",
       "triggerID" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f1f147b44eb287ba95d31f98609da975705b94e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3322) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] manojpec commented on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
manojpec commented on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966801445


   @vinothchandar 
   
   I added the support for metadata table rolling back the first commit when needed - https://issues.apache.org/jira/browse/HUDI-2468,  https://github.com/apache/hudi/pull/3843 and it helps these rollback related test cases to pass now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966764313


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f1f147b44eb287ba95d31f98609da975705b94e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3978:
URL: https://github.com/apache/hudi/pull/3978


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966764313


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f1f147b44eb287ba95d31f98609da975705b94e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966765464


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3322",
       "triggerID" : "8f1f147b44eb287ba95d31f98609da975705b94e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f1f147b44eb287ba95d31f98609da975705b94e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3322) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3978: [HUDI-2472] Enabling metadata table in TestHoodieIndex and TestMergeOnReadRollbackActionExecutor

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3978:
URL: https://github.com/apache/hudi/pull/3978#issuecomment-966772706


   Could you please expand? Are we adding new functionality to make these tests pass?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org