You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2004/01/11 23:07:47 UTC
New date parser ready for re-review
I believe I have addressed all of gstein's issues about the date
parser, as well as some issues I found myself today.
http://subversion.tigris.org/nonav/issues/showattachment.cgi/270/diff
contains the updated patch.
To gstein: Please verify that the issues you presented have been
addressed, and consider withdrawing your veto.
To fitz: I am told that chapter 3 of the book is your chapter.
http://subversion.tigris.org/nonav/issues/showattachment.cgi/271/doc-diff
contains a suggested minimal change to the book for the new date
parser, but you may wish to make more extensive changes. The main
patch includes an addition to doc/book/REVIEW which should help you
document the new date parser.
(Chapter 9 also needs a small tweak; doc-diff has that as well. I
don't know whose chapter that is.)
To all who reviewed #408: your +1 votes are out of date. Please
review the new diff. Changes vs. the old diff include:
* Tests for svn_parse_date() have been added.
* A subtle daylight savings time issue has been addressed. As a
consequence, the new svn_parse_date() API no longer takes a gmtoff
parameter, since the local time zone cannot be expressed as a
single number. (The GMT offset for the parsed time may not be the
same as the GMT offset for the current time, since one may be in
DST while the other is not.)
* The date formats have been changed to require minutes when there
are hours, and to require a time when there is a time zone,
following the lead of:
http://www.w3.org/TR/NOTE-datetime
* The date templates have been fixed to process time zone offsets
correctly.
* The template parser verifies that explicit time zone offsets are
within bounds, since that cannot be done once the offset has been
combined into a single number.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: New date parser ready for re-review
Posted by "Brian. W. Fitzpatrick" <fi...@red-bean.com>.
On Sun, 2004-01-11 at 17:07, Greg Hudson wrote:
> To fitz: I am told that chapter 3 of the book is your chapter.
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/271/doc-diff
> contains a suggested minimal change to the book for the new date
> parser, but you may wish to make more extensive changes. The main
> patch includes an addition to doc/book/REVIEW which should help you
> document the new date parser.
Gotcha. I'll track IZ 408 and help out where I can.
Thanks!
-Fitz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: New date parser ready for re-review
Posted by br...@xbc.nu.
Quoting Greg Hudson <gh...@MIT.EDU>:
> I believe I have addressed all of gstein's issues about the date
> parser, as well as some issues I found myself today.
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/270/diff
> contains the updated patch.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: New date parser ready for re-review
Posted by Greg Stein <gs...@lyra.org>.
On Sun, Jan 11, 2004 at 06:07:47PM -0500, Greg Hudson wrote:
> I believe I have addressed all of gstein's issues about the date
> parser, as well as some issues I found myself today.
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/270/diff
> contains the updated patch.
>
> To gstein: Please verify that the issues you presented have been
> addressed, and consider withdrawing your veto.
Absolutely! Thanks so much for the efforts. I realize that you put in a
bunch of extra work for this, which I suspect you hadn't intended on. But
given "where we are", it just didn't seem right to go without the extra
tests. And given Philip's findings, it makes me a bit glad that you went
the extra distance.
I should be able to get to this later tonite, tomorrow at the latest.
Thanks,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org