You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/20 12:54:21 UTC
[GitHub] sven-lange-last opened a new pull request #2782: Add git pre-commit hook scripts for Scala formatting
sven-lange-last opened a new pull request #2782: Add git pre-commit hook scripts for Scala formatting
URL: https://github.com/apache/incubator-openwhisk/pull/2782
Provided scripts can be used to apply project standard Scala formatting automatically
when committing Scala source files. Developers only need to add the invocation
of any of the scripts to their git `pre-commit` hook file.
Standard Scala formatting was added with pull request #2650. At the moment,
https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#scala
describes how the `pre-commit` hook can be extended to apply Scala formatting.
The script provided at this location has some flaws that are addressed by this PR:
* The existing script starts formatting if Scala files are removed.
* The existing script does not work if no `build.gradle` file can be found
in the current working directory.
* The existing script does only consider Scala files in the current
working directory or below the current working directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services