You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Zhi Hong Yang <zh...@cn.ibm.com> on 2013/01/18 09:55:20 UTC
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 8:55 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Summary (updated)
-----------------
PropertyNotFoundException handle(Variable Substitution should support EL syntax)
Description (updated)
-------
In https://reviews.apache.org/r/8184/ patch, there is a bug:
When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
This addresses bug shindig-1588.
https://issues.apache.org/jira/browse/shindig-1588
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1435051
Diff: https://reviews.apache.org/r/9017/diff/
Testing
-------
Thanks,
Zhi Hong Yang
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
Posted by Marshall Shi <sh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/#review15535
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
<https://reviews.apache.org/r/9017/#comment33541>
Can we catch PropertyNotFoundException here rather than the general Exception?
Also, logging the exact variable that can't be parsed would provide more accurate info.
- Marshall Shi
On Jan. 21, 2013, 4:44 a.m., Zhi Hong Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9017/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2013, 4:44 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> In https://reviews.apache.org/r/8184/ patch, there is a bug:
> When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
>
>
> This addresses bug shindig-1588.
> https://issues.apache.org/jira/browse/shindig-1588
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1436200
>
> Diff: https://reviews.apache.org/r/9017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhi Hong Yang
>
>
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/#review15537
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On Jan. 21, 2013, 7:15 a.m., Zhi Hong Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9017/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2013, 7:15 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> In https://reviews.apache.org/r/8184/ patch, there is a bug:
> When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
>
>
> This addresses bug shindig-1588.
> https://issues.apache.org/jira/browse/shindig-1588
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1436200
>
> Diff: https://reviews.apache.org/r/9017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhi Hong Yang
>
>
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
Posted by Zhi Hong Yang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/
-----------------------------------------------------------
(Updated Jan. 21, 2013, 7:15 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Description
-------
In https://reviews.apache.org/r/8184/ patch, there is a bug:
When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
This addresses bug shindig-1588.
https://issues.apache.org/jira/browse/shindig-1588
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1436200
Diff: https://reviews.apache.org/r/9017/diff/
Testing
-------
Thanks,
Zhi Hong Yang
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
Posted by Zhi Hong Yang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/
-----------------------------------------------------------
(Updated Jan. 21, 2013, 4:44 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Description
-------
In https://reviews.apache.org/r/8184/ patch, there is a bug:
When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
This addresses bug shindig-1588.
https://issues.apache.org/jira/browse/shindig-1588
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1436200
Diff: https://reviews.apache.org/r/9017/diff/
Testing
-------
Thanks,
Zhi Hong Yang
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/#review15518
-----------------------------------------------------------
Ship it!
LGTM except for the issue Dan pointed out.
- Ryan Baxter
On Jan. 18, 2013, 8:55 a.m., Zhi Hong Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9017/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 8:55 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> In https://reviews.apache.org/r/8184/ patch, there is a bug:
> When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
>
>
> This addresses bug shindig-1588.
> https://issues.apache.org/jira/browse/shindig-1588
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1435051
>
> Diff: https://reviews.apache.org/r/9017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhi Hong Yang
>
>
Re: Review Request: PropertyNotFoundException handle(Variable Substitution
should support EL syntax)
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/#review15488
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
<https://reviews.apache.org/r/9017/#comment33434>
Looks like you lost the break statement after the catch.
- Dan Dumont
On Jan. 18, 2013, 8:55 a.m., Zhi Hong Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9017/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 8:55 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> In https://reviews.apache.org/r/8184/ patch, there is a bug:
> When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL.
>
>
> This addresses bug shindig-1588.
> https://issues.apache.org/jira/browse/shindig-1588
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1435051
>
> Diff: https://reviews.apache.org/r/9017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhi Hong Yang
>
>