[GitHub] [hbase] comnetwork commented on a change in pull request #3533: HBASE-26144 The HStore.snapshot method is never called in main code

[GitBox <gi...@apache.org>]

comnetwork commented on a change in pull request #3533:
URL: https://github.com/apache/hbase/pull/3533#discussion_r678787345



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1251,6 +1234,9 @@ private boolean updateStorefiles(List<HStoreFile> sfs, long snapshotId) throws I
       // the lock.
       this.lock.writeLock().unlock();
     }
+    if (snapshotId > 0) {
+      this.memstore.clearSnapshot(snapshotId);

Review comment:
       Maybe we could add some comments here why we can clear snapshot outside the writeLock.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org