You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/01/18 04:18:55 UTC
[kudu-CR] Enable vptr UBSAN checker
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9051
Change subject: Enable vptr UBSAN checker
......................................................................
Enable vptr UBSAN checker
The issue with boost intrusive list no longer appears to be relevant. If
it reappears we can add the corresponding functions to the UBSAN
blacklist instead of disabling the check across the board.
Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/9051/1
--
To view, visit http://gerrit.cloudera.org:8080/9051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Gerrit-Change-Number: 9051
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
[kudu-CR] Enable vptr UBSAN checker
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 )
Change subject: Enable vptr UBSAN checker
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Gerrit-Change-Number: 9051
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 18 Jan 2018 17:00:03 +0000
Gerrit-HasComments: No
[kudu-CR] Enable vptr UBSAN checker
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 )
Change subject: Enable vptr UBSAN checker
......................................................................
Patch Set 2:
Carrying over the +2 from Todd and Alexey.
--
To view, visit http://gerrit.cloudera.org:8080/9051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Gerrit-Change-Number: 9051
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 18 Jan 2018 21:41:33 +0000
Gerrit-HasComments: No
[kudu-CR] Enable vptr UBSAN checker
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 )
Change subject: Enable vptr UBSAN checker
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Gerrit-Change-Number: 9051
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 18 Jan 2018 17:54:01 +0000
Gerrit-HasComments: No
[kudu-CR] Enable vptr UBSAN checker
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 )
Change subject: Enable vptr UBSAN checker
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Gerrit-Change-Number: 9051
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 18 Jan 2018 21:41:07 +0000
Gerrit-HasComments: No
[kudu-CR] Enable vptr UBSAN checker
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9051 )
Change subject: Enable vptr UBSAN checker
......................................................................
Enable vptr UBSAN checker
The issue with boost intrusive list no longer appears to be relevant. If
it reappears we can add the corresponding functions to the UBSAN
blacklist instead of disabling the check across the board.
Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Reviewed-on: http://gerrit.cloudera.org:8080/9051
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Gerrit-Change-Number: 9051
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>