You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shivusondur <gi...@git.apache.org> on 2018/09/27 09:49:04 UTC

[GitHub] spark pull request #22567: [WIP]Environment Page of Spark Job History UI sho...

GitHub user shivusondur reopened a pull request:

    https://github.com/apache/spark/pull/22567

    [WIP]Environment Page of Spark Job History UI showing wrong value for spark.ui.retainedJobs

    ## What changes were proposed in this pull request?
    Currently, in History page, Number of Jobs in the jobs page and "spark.ui.retainedJobs" value is not matching, as the environment page always takes the spark properties to display
    so need to override the spark properties from the History properties, which will match the number of jobs showing in jobs page and value of "spark.ui.retainedJobs" in the Environment Page.
    Same applies to other History specific parameters such as "spark.ui.retainedTasks" 
    
    ## How was this patch tested?
    Tested in spark 2.5.0 version.
    1. In the spark-default.conf mentioned the spark.ui.retainedJobs=200
    2. In spark shell command mentioned the 100 like below command
         "spark-shell --master yarn --conf spark.ui.retainedJobs=100"
    
    Attached the test result screenshot
    spark.ui.retainedJobs is showing specific to historypage
    Now the total jobs showing and the spark.ui,retainedJobs value in the Environment page are matching.
    
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shivusondur/spark EnvPageHistory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22567
    
----
commit 379493e399fab12f36ab2b16d67ec18d8eb591d9
Author: Shahid <sh...@...>
Date:   2018-09-27T06:19:13Z

    Test

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org