You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/16 20:47:31 UTC
[GitHub] [beam] Abacn opened a new pull request, #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Abacn opened a new pull request, #24211:
URL: https://github.com/apache/beam/pull/24211
Part of #18204
HadoopFormatIO, CdapIO, SparkReceiveIO are running performance tests on relatively small dataset (600k) which take only several seconds. The metrics obtained is thus barely meaningful to detect any regression / comparing performances. Bumping them to 5M, the same number used for JdbcIO performance tests. These tests all used the same TestRow so they are processing exactly same data and their metrics are now comparable.
Adjusted the run interval from 6 h to 12 h as they do not need to run that frequently.
Also add SingleStoreIO dashboard which is almost done; and some fixes on Python dashboard.
* CdapIO, SparkReceiver Performance test match data size for JDBC
* Set frequency to 12 h (performance tests not need to exercise very frequent)
* Add SingleStoreIO dashboard
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24211:
URL: https://github.com/apache/beam/pull/24211#issuecomment-1317727614
R: @aromanenko-dev (for newly added CdapIO and SparkReceiverIO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24211:
URL: https://github.com/apache/beam/pull/24211#discussion_r1028320756
##########
.test-infra/jenkins/job_PerformanceTests_CdapIO.groovy:
##########
@@ -24,7 +24,7 @@ String jobName = "beam_PerformanceTests_Cdap"
job(jobName) {
common.setTopLevelMainJobProperties(delegate)
- common.setAutoJob(delegate, 'H H/6 * * *')
+ common.setAutoJob(delegate, 'H H/12 * * *')
Review Comment:
yeah agree. When more performance tests are added we can further reduce the frequency. Just a trivial change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24211:
URL: https://github.com/apache/beam/pull/24211#issuecomment-1317650932
R: @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24211:
URL: https://github.com/apache/beam/pull/24211#issuecomment-1317652282
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #24211:
URL: https://github.com/apache/beam/pull/24211#discussion_r1025361449
##########
.test-infra/jenkins/job_PerformanceTests_CdapIO.groovy:
##########
@@ -24,7 +24,7 @@ String jobName = "beam_PerformanceTests_Cdap"
job(jobName) {
common.setTopLevelMainJobProperties(delegate)
- common.setAutoJob(delegate, 'H H/6 * * *')
+ common.setAutoJob(delegate, 'H H/12 * * *')
Review Comment:
Actually, I think we can run perf tests even only once per day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #24211: Unify test parameters for certain IOs based on test row and grafana fixes
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #24211:
URL: https://github.com/apache/beam/pull/24211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org