You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/06/25 14:59:35 UTC
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/868
[tools] Make release script a bit more flexible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink release_script
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/868.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #868
----
commit 1cefd8abd3a0527f380f22db0baae6bebb2a952f
Author: Robert Metzger <rm...@apache.org>
Date: 2015-06-25T12:58:08Z
[tools] Make release script a bit more flexible
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-119618256
I needed to make these changes to the script when I created the additional binaries for hadoop24,hadoop26,...
For that I needed to create binaries without deploying stuff to maven again. Thats why I put these operations into separate functions so that I can control whether they are executed or not.
I'll merge this change now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115770279
Thanks @mxm , yeah I guess it is a refactoring. I was trying to figure out what changes make it more flexible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115601791
@hsaputra This is just refactoring. I think your changes improve the readability of the code. Like Ufuk mentioned, it does not necessarily make the script more flexible. Due to side effects of the function calls they need to be called in a specific order. It does make the script "a bit more flexible" though :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/868#discussion_r33340726
--- Diff: tools/create_release_files.sh ---
@@ -138,7 +146,7 @@ make_binary_release() {
echo "Files in uberjar: $NUM_FILES_IN_UBERJAR. Uberjar: $UBERJAR"
if [ "$NUM_FILES_IN_UBERJAR" -ge "65536" ] ; then
echo "The number of files in the uberjar ($NUM_FILES_IN_UBERJAR) exceeds the maximum number of possible files for Java 6 (65536)"
- exit 1
+ # exit 1
--- End diff --
Shouldn't we fail here? What's the point of the check after all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/868#discussion_r33340734
--- Diff: tools/create_release_files.sh ---
@@ -85,37 +87,43 @@ else
fi
+prepare() {
+ # prepare
+ git clone http://git-wip-us.apache.org/repos/asf/flink.git flink
+ cd flink
+ git checkout -b "$RELEASE_VERSION-$RELEASE_CANDIDATE" origin/$RELEASE_BRANCH
+ rm -f .gitignore
+ rm -f .travis.yml
+ rm -f deploysettings.xml
+ rm -f CHANGELOG
+}
+
# create source package
-git clone http://git-wip-us.apache.org/repos/asf/flink.git flink
-cd flink
-git checkout -b "$RELEASE_VERSION-$RELEASE_CANDIDATE" origin/$RELEASE_BRANCH
-rm -f .gitignore
-rm -f .travis.yml
-rm -f deploysettings.xml
-rm -f CHANGELOG
-
-#find . -name 'pom.xml' -type f -exec sed -i 's#<version>$OLD_VERSION</version>#<version>$NEW_VERSION</version>#' {} \;
-if [ "$(uname)" == "Darwin" ]; then
- find . -name 'pom.xml' -type f -exec sed -i "" 's#<version>'$OLD_VERSION'</version>#<version>'$NEW_VERSION'</version>#' {} \;
-else
- find . -name 'pom.xml' -type f -exec sed -i 's#<version>'$OLD_VERSION'</version>#<version>'$NEW_VERSION'</version>#' {} \;
-fi
+make_source_release() {
-git commit --author="$GIT_AUTHOR" -am "Commit for release $RELEASE_VERSION"
-git remote add asf_push https://$USER_NAME@git-wip-us.apache.org/repos/asf/flink.git
-RELEASE_HASH=`git rev-parse HEAD`
-echo "Echo created release hash $RELEASE_HASH"
+ #find . -name 'pom.xml' -type f -exec sed -i 's#<version>$OLD_VERSION</version>#<version>$NEW_VERSION</version>#' {} \;
--- End diff --
I think you can remove this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115366539
HI @rmetzger, could you summarize the intention of the PR here? Like what is the final goal of the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115262360
Good changes +1
There are some assumptions about the call order of the newly introduced functions though (like you have to call prepare make_src_release [or be in the checked out repo] in that order). I guess it's fine, we don't want to over engineer this ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/868
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---