You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/05/22 00:32:47 UTC

Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/
-----------------------------------------------------------

(Updated May 21, 2015, 10:32 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.


Summary (updated)
-----------------

RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz


Bugs: AMBARI-11306
    https://issues.apache.org/jira/browse/AMBARI-11306


Repository: ambari


Description
-------

[PREVIEW]

Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
  ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
  ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
  ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
  ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
  ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
  ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
  ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
  ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
  ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
  ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
  ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
  ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 

Diff: https://reviews.apache.org/r/34548/diff/


Testing (updated)
-------

Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.

----------------------------------------------------------------------
Total run:741
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/#review84831
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On May 21, 2015, 6:32 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34548/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 6:32 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11306
>     https://issues.apache.org/jira/browse/AMBARI-11306
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
> Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
>   ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
>   ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
>   ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 
> 
> Diff: https://reviews.apache.org/r/34548/diff/
> 
> 
> Testing
> -------
> 
> Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
> App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.
> 
> ----------------------------------------------------------------------
> Total run:741
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/#review84826
-----------------------------------------------------------

Ship it!


Mostly nits; Nice and clean!


ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py
<https://reviews.apache.org/r/34548/#comment136223>

    If you're raising an exception then I'd guess it would be valuable to know what the PID file was ... maybe make this INFO?



ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
<https://reviews.apache.org/r/34548/#comment136226>

    What other direction would there be, sideways? I don't think we need that check here since it's for either up or down



ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
<https://reviews.apache.org/r/34548/#comment136227>

    My god - the indents! I dislike this form :)


- Jonathan Hurley


On May 21, 2015, 6:32 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34548/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 6:32 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11306
>     https://issues.apache.org/jira/browse/AMBARI-11306
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
> Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
>   ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
>   ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
>   ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 
> 
> Diff: https://reviews.apache.org/r/34548/diff/
> 
> 
> Testing
> -------
> 
> Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
> App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.
> 
> ----------------------------------------------------------------------
> Total run:741
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/
-----------------------------------------------------------

(Updated May 22, 2015, 3:09 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-11306
    https://issues.apache.org/jira/browse/AMBARI-11306


Repository: ambari


Description
-------

Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
  ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 839d980 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py ea70b8a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 934aadf 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 90b23de 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3859236 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 494e138 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 9025b48 
  ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json d0c164e 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
  ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
  ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 097097d 
  ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
  ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
  ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
  ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json dce5cae 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
  ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
  ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
  ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
  ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 

Diff: https://reviews.apache.org/r/34548/diff/


Testing
-------

Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.

----------------------------------------------------------------------
Total run:741
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/
-----------------------------------------------------------

(Updated May 22, 2015, 2:34 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-11306
    https://issues.apache.org/jira/browse/AMBARI-11306


Repository: ambari


Description
-------

Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
  ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 839d980 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py ea70b8a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 934aadf 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 90b23de 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3859236 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 494e138 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 9025b48 
  ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json d0c164e 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
  ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
  ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 097097d 
  ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
  ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
  ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
  ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json dce5cae 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
  ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
  ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
  ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
  ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 

Diff: https://reviews.apache.org/r/34548/diff/


Testing
-------

Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.

----------------------------------------------------------------------
Total run:741
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On May 21, 2015, 10:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py, line 215
> > <https://reviews.apache.org/r/34548/diff/2/?file=968289#file968289line215>
> >
> >     General robustness.
> 
> Jonathan Hurley wrote:
>     Instead of returning None which you can't split on, can you return "" ?

Sure


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/#review84806
-----------------------------------------------------------


On May 21, 2015, 10:32 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34548/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 10:32 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11306
>     https://issues.apache.org/jira/browse/AMBARI-11306
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
> Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
>   ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
>   ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
>   ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 
> 
> Diff: https://reviews.apache.org/r/34548/diff/
> 
> 
> Testing
> -------
> 
> Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
> App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.
> 
> ----------------------------------------------------------------------
> Total run:741
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On May 21, 2015, 6:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py, line 215
> > <https://reviews.apache.org/r/34548/diff/2/?file=968289#file968289line215>
> >
> >     General robustness.

Instead of returning None which you can't split on, can you return "" ?


> On May 21, 2015, 6:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py, line 21
> > <https://reviews.apache.org/r/34548/diff/2/?file=968290#file968290line21>
> >
> >     Fixed imports wherever I saw it.

+1 !


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/#review84806
-----------------------------------------------------------


On May 21, 2015, 6:32 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34548/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 6:32 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11306
>     https://issues.apache.org/jira/browse/AMBARI-11306
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
> Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
>   ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
>   ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
>   ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 
> 
> Diff: https://reviews.apache.org/r/34548/diff/
> 
> 
> Testing
> -------
> 
> Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
> App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.
> 
> ----------------------------------------------------------------------
> Total run:741
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/#review84806
-----------------------------------------------------------


The 2nd page is all json files that can be ignored, the 3rd page is all unit tests.


ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
<https://reviews.apache.org/r/34548/#comment136184>

    This is the most important file in this change.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/34548/#comment136186>

    General robustness.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
<https://reviews.apache.org/r/34548/#comment136187>

    Fixed imports wherever I saw it.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
<https://reviews.apache.org/r/34548/#comment136188>

    Completely reorganized this.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
<https://reviews.apache.org/r/34548/#comment136189>

    This needed both mapreduce and tez.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/34548/#comment136190>

    Hive is special because it has to account for both HDP 2.1, and higher.



ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/34548/#comment136191>

    None of these configs are needed any more. I may remove them from cluster-env in the UpgradeCatalog.


- Alejandro Fernandez


On May 21, 2015, 10:32 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34548/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 10:32 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11306
>     https://issues.apache.org/jira/browse/AMBARI-11306
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
> Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
>   ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
>   ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
>   ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
>   ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
>   ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
>   ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 
> 
> Diff: https://reviews.apache.org/r/34548/diff/
> 
> 
> Testing
> -------
> 
> Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
> App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.
> 
> ----------------------------------------------------------------------
> Total run:741
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 34548: RU to copy correct version of tarball, including tez.tar.gz and mapreduce.tar.gz

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34548/
-----------------------------------------------------------

(Updated May 21, 2015, 10:32 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-11306
    https://issues.apache.org/jira/browse/AMBARI-11306


Repository: ambari


Description (updated)
-------

Summary: Customers with Ambari 2.0.0 that performed an RU from say HDP 2.2.0.0 to 2.2.4.2 will not have the correct version of tarballs uploaded to HDFS.
Impact: Applications that depend on this tarball (Pig, Tez, Hive) will be running with older classes. This does not appear to be breaking in HDP 2.2, otherwise customers would have reported it. However, it certainly does have to be fixed in Ambari 2.1.0 because tez.tar.gz and mapreduce.tar.gz hav more significant changes and does encounter a version incompatibility error.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py 21cb3bb 
  ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 6bd6599 
  ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 92a043f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 3f1fb0d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6edca7d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py aeac939 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 86312d2 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 11b439b 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py fc39bc6 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py 5f33b1d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py c96be5d 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 34d1cb8 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py f5b0167 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 840b81d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 6b56511 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py da7b9b4 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py b0393a0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py ebef301 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml 485125c 
  ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/configuration/cluster-env.xml.version 485125c 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json f1d08b9 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.2.json 86521d1 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.0_to_2.2.4.json 7721c67 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.2.json a040268 
  ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_2.1_to_2.2.4.json ba2b3d7 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 90f3e06 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 79e3697 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bc527e7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py a2ee27f 
  ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json aeecb79 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 485e882 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 9502b14 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 4465ca7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json ac95268 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json fa48c6d 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 88017b5 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json fc798c2 
  ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 3109b7a 
  ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5999fb7 
  ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json a9113c4 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8616f3d 
  ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json 4a2dc97 
  ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 1534619 
  ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py 039b14d 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 4e8ec42 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py a02a908 
  ambari-server/src/test/python/stacks/2.2/configs/default.json 8c85311 
  ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json c54a4e6 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json c4d7f6b 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3b6a2fa 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 9d8cb39 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 06cd36e 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 19db471 
  ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json a7a6121 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 3e6307d 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json caec8ca 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json dc674fe 
  ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json 131cf19 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json b1209d0 
  ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 99d5c78 
  ambari-server/src/test/python/stacks/2.3/configs/storm_default.json b8b06eb 
  ambari-server/src/test/resources/custom_actions/ru_execute_tasks_namenode_prepare.json 368ddc5 

Diff: https://reviews.apache.org/r/34548/diff/


Testing
-------

Deplyed cluster with Ambari 2.1 and HDP 2.3, with patched files, was able to restart, and get status, run Service Checks for these services:
App Timeline Server, ResourceManager, HiveServer2, Spark HistoryServer, Pig, Tez, Sqoop.

----------------------------------------------------------------------
Total run:741
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez