[jira] Commented: (SLING-1508) Default auth handlers are not considered if a handler has a protocol or host

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863841#action_12863841 ] 

Carsten Ziegeler commented on SLING-1508:
-----------------------------------------

I've provided a potential patch which is based on the old SlingAuthenticator code from the engine - the benefit (if it works correctly....) is that with the
patch there is no synchronization anymore when accessing the holders.
The patch looks wilder than it is, as I changed the return types to use the List interface instead of the ArrayList implementation....

> Default auth handlers are not considered if a handler has a protocol or host
> ----------------------------------------------------------------------------
>
>                 Key: SLING-1508
>                 URL: https://issues.apache.org/jira/browse/SLING-1508
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>    Affects Versions: Commons Auth 1.0.0
>            Reporter: Carsten Ziegeler
>             Fix For: Commons Auth 1.0.0
>
>         Attachments: SLING1508
>
>
> The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
> If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
> So as soon as one handler has a protocol/host, default handlers are not considered anymore

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.