You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/15 18:18:15 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6626: stm32: hide STM32xx_SPI_DMA option and select it automatically
raiden00pl opened a new pull request, #6626:
URL: https://github.com/apache/incubator-nuttx/pull/6626
## Summary
- stm32: hide STM32xx_SPI_DMA option and select it automatically.
This only applies to stm32 archs with individually configured SPI DMA (no stm32l4, stm32l5, stm32u5, stm32wb).
- stm32/Kconfig: set default n for hidden options
- stm32f0l0g0/Kconfig: remove the duplicated SPI DMA section
- stm32f0l0g0/Kconfig: set default n for hidden options
- boards: remove references to STM32xx_SPI_DMA, which is now a hidden option
## Impact
Selects the STM32xx_SPI_DMA option automatically if any SPI DMA has been enabled.
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6626: stm32: hide STM32xx_SPI_DMA option and select it automatically
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6626:
URL: https://github.com/apache/incubator-nuttx/pull/6626#discussion_r922480262
##########
boards/arm/stm32/mikroe-stm32f4/configs/fulldemo/defconfig:
##########
@@ -129,7 +129,6 @@ CONFIG_STM32_PWR=y
CONFIG_STM32_RNG=y
CONFIG_STM32_RTC=y
CONFIG_STM32_SPI2=y
-CONFIG_STM32_SPI_DMA=y
Review Comment:
Why this is removed, but not changed to `CONFIG_STM32_SPI2_DMA`? Same for other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a diff in pull request #6626: stm32: hide STM32xx_SPI_DMA option and select it automatically
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on code in PR #6626:
URL: https://github.com/apache/incubator-nuttx/pull/6626#discussion_r922511195
##########
boards/arm/stm32/mikroe-stm32f4/configs/fulldemo/defconfig:
##########
@@ -129,7 +129,6 @@ CONFIG_STM32_PWR=y
CONFIG_STM32_RNG=y
CONFIG_STM32_RTC=y
CONFIG_STM32_SPI2=y
-CONFIG_STM32_SPI_DMA=y
Review Comment:
CONFIG_STM32_SPI_DMA=y didn't affect the SPI DMA configuration at all. Without CONFIG_STM32_SPIx_DMA=y it was just a dummy option.
.rxch = 0 and .txch = 0 here:
https://github.com/apache/incubator-nuttx/blob/3c0a3dabfce4c5da866ee25966c3125bba8a0453/arch/arm/src/stm32/stm32_spi.c#L360-L373
So I left it as it was, with DMA disabled for SPI2. Same for other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6626: stm32: hide STM32xx_SPI_DMA option and select it automatically
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6626:
URL: https://github.com/apache/incubator-nuttx/pull/6626#discussion_r922649642
##########
boards/arm/stm32/mikroe-stm32f4/configs/fulldemo/defconfig:
##########
@@ -129,7 +129,6 @@ CONFIG_STM32_PWR=y
CONFIG_STM32_RNG=y
CONFIG_STM32_RTC=y
CONFIG_STM32_SPI2=y
-CONFIG_STM32_SPI_DMA=y
Review Comment:
Thank you for clarification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6626: stm32: hide STM32xx_SPI_DMA option and select it automatically
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6626:
URL: https://github.com/apache/incubator-nuttx/pull/6626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org