You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/30 14:29:59 UTC
[GitHub] [flink] miklosgergely opened a new pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
miklosgergely opened a new pull request #13525:
URL: https://github.com/apache/flink/pull/13525
## What is the purpose of the change
At HBase 2.2.3 the test mini cluster utility only works with hadoop 2.8.0 - 3.0.3, thus the integration tests should not run with other hadoop versions. It is causing issues in the nightly tests that run them with 2.4.1 and 3.1.3
## Brief change log
HBaseConnectorITCase now runs only if hadoop.version is within 2.8.0 - 3.0.3
## Verifying this change
HBaseConnectorITCase is skipped if it is executed with a hadoop.version ourside of the 2.8.0 - 3.0.3 range.
This change added tests and can be verified as follows: running the tests with different -Dhadoop.version=... settings
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701444731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7309386d95647358780ec4e8a615567f720c7987",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134",
"triggerID" : "7309386d95647358780ec4e8a615567f720c7987",
"triggerType" : "PUSH"
}, {
"hash" : "df45481e9c3a07bcbfac6e070bc16a38fe83f3ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df45481e9c3a07bcbfac6e070bc16a38fe83f3ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7309386d95647358780ec4e8a615567f720c7987 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134)
* df45481e9c3a07bcbfac6e070bc16a38fe83f3ce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #13525:
URL: https://github.com/apache/flink/pull/13525#discussion_r497865775
##########
File path: flink-connectors/flink-connector-hbase-2.2/pom.xml
##########
@@ -45,6 +45,9 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<version>2.19.1</version>
<configuration>
+ <systemPropertyVariables>
Review comment:
I guess this change is not necessary?
##########
File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/util/HBaseTestingClusterAutoStarter.java
##########
@@ -119,6 +123,9 @@ private static void initialize(Configuration c) {
@BeforeClass
public static void setUp() throws Exception {
+ // HBase 2.2.3 HBaseTestingUtility works with only a certain range of hadoop versions
+ String hadoopVersion = System.getProperty("hadoop.version");
+ Assume.assumeTrue(HADOOP_VERSION_RANGE.contains(hadoopVersion));
Review comment:
There is a utility org.apache.hadoop.util.VersionUtil provided in hadoop for comparing version. What about making use of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701444731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7309386d95647358780ec4e8a615567f720c7987",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134",
"triggerID" : "7309386d95647358780ec4e8a615567f720c7987",
"triggerType" : "PUSH"
}, {
"hash" : "df45481e9c3a07bcbfac6e070bc16a38fe83f3ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7147",
"triggerID" : "df45481e9c3a07bcbfac6e070bc16a38fe83f3ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7309386d95647358780ec4e8a615567f720c7987 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134)
* df45481e9c3a07bcbfac6e070bc16a38fe83f3ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] miklosgergely commented on a change in pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #13525:
URL: https://github.com/apache/flink/pull/13525#discussion_r498058981
##########
File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/util/HBaseTestingClusterAutoStarter.java
##########
@@ -119,6 +123,9 @@ private static void initialize(Configuration c) {
@BeforeClass
public static void setUp() throws Exception {
+ // HBase 2.2.3 HBaseTestingUtility works with only a certain range of hadoop versions
+ String hadoopVersion = System.getProperty("hadoop.version");
+ Assume.assumeTrue(HADOOP_VERSION_RANGE.contains(hadoopVersion));
Review comment:
Range is using VersionUtil::compareVersions now to compare.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #13525:
URL: https://github.com/apache/flink/pull/13525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701430487
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7309386d95647358780ec4e8a615567f720c7987 (Wed Sep 30 14:33:04 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19447).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] miklosgergely commented on a change in pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #13525:
URL: https://github.com/apache/flink/pull/13525#discussion_r498058649
##########
File path: flink-connectors/flink-connector-hbase-2.2/pom.xml
##########
@@ -45,6 +45,9 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<version>2.19.1</version>
<configuration>
+ <systemPropertyVariables>
Review comment:
Indeed. Removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701444731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7309386d95647358780ec4e8a615567f720c7987",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134",
"triggerID" : "7309386d95647358780ec4e8a615567f720c7987",
"triggerType" : "PUSH"
}, {
"hash" : "df45481e9c3a07bcbfac6e070bc16a38fe83f3ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7147",
"triggerID" : "df45481e9c3a07bcbfac6e070bc16a38fe83f3ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df45481e9c3a07bcbfac6e070bc16a38fe83f3ce Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701444731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7309386d95647358780ec4e8a615567f720c7987",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7309386d95647358780ec4e8a615567f720c7987",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7309386d95647358780ec4e8a615567f720c7987 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701444731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7309386d95647358780ec4e8a615567f720c7987",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134",
"triggerID" : "7309386d95647358780ec4e8a615567f720c7987",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7309386d95647358780ec4e8a615567f720c7987 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701444731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7309386d95647358780ec4e8a615567f720c7987",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134",
"triggerID" : "7309386d95647358780ec4e8a615567f720c7987",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7309386d95647358780ec4e8a615567f720c7987 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7134)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13525:
URL: https://github.com/apache/flink/pull/13525#issuecomment-701430487
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit df45481e9c3a07bcbfac6e070bc16a38fe83f3ce (Fri Feb 19 07:32:24 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org