[jira] [Commented] (SOLR-8674) transition from solr.tests.mergePolicy to solr.tests.mergePolicyFactory

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154219#comment-15154219 ] 

Christine Poerschke commented on SOLR-8674:
-------------------------------------------

Attached proposed patch against master, with the change {{solr.tests.mergePolicy\[Factory\]}} tests now randomly choose between <mergePolicy> and <mergePolicyFactory>
* This increases <mergePolicy> vs. <mergePolicyFactory> test coverage.
* This temporarily also adds a little test setup complexity but when SOLR-8668 removes support for <mergePolicy> then test setup will return to its original complexity.

[~shaie] - with this following on from SOLR-8621, would you have a chance to review the patch at some point? Thanks.



> transition from solr.tests.mergePolicy to solr.tests.mergePolicyFactory
> -----------------------------------------------------------------------
>
>                 Key: SOLR-8674
>                 URL: https://issues.apache.org/jira/browse/SOLR-8674
>             Project: Solr
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>         Attachments: SOLR-8674.patch
>
>
> Following on from SOLR-8621 which deprecated/replaced <mergePolicy> with <mergePolicyFactory> there are some test solrconfig.xml files and associated test code that need to be transitioned from
> {code}
> <mergePolicy class="${solr.tests.mergePolicy:org.apache.solr.util.RandomMergePolicy}"/>
> {code}
> to
> {code}
> <mergePolicyFactory class="${solr.tests.mergePolicyFactory:org.apache.solr.util.RandomMergePolicyFactory}"/>
> {code}
> or something similar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org