You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2020/01/13 09:55:55 UTC
[james-project] 09/10: [Refactoring] throwing tests for BlobStore
should actually read() to ensure lazy streams are evaluated
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 694d36a2f14b788743e3ffe8c91caef7abc71af0
Author: Matthieu Baechler <ma...@apache.org>
AuthorDate: Mon Jan 6 15:12:20 2020 +0100
[Refactoring] throwing tests for BlobStore should actually read() to ensure lazy streams are evaluated
---
.../src/test/java/org/apache/james/blob/api/BlobStoreContract.java | 2 +-
.../test/java/org/apache/james/blob/api/BucketBlobStoreContract.java | 4 ++--
.../test/java/org/apache/james/blob/api/DeleteBlobStoreContract.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java
index 2067d70..0fd6961 100644
--- a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java
+++ b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java
@@ -211,7 +211,7 @@ public interface BlobStoreContract extends DeleteBlobStoreContract, BucketBlobSt
BlobStore store = testee();
BucketName defaultBucketName = store.getDefaultBucketName();
- assertThatThrownBy(() -> store.read(defaultBucketName, blobIdFactory().from("unknown")))
+ assertThatThrownBy(() -> store.read(defaultBucketName, blobIdFactory().from("unknown")).read())
.isInstanceOf(ObjectNotFoundException.class);
}
diff --git a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BucketBlobStoreContract.java b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BucketBlobStoreContract.java
index a52240e..0d993bd 100644
--- a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BucketBlobStoreContract.java
+++ b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BucketBlobStoreContract.java
@@ -55,7 +55,7 @@ public interface BucketBlobStoreContract {
BlobId blobId = store.save(CUSTOM, SHORT_BYTEARRAY, LOW_COST).block();
store.deleteBucket(CUSTOM).block();
- assertThatThrownBy(() -> store.read(CUSTOM, blobId))
+ assertThatThrownBy(() -> store.read(CUSTOM, blobId).read())
.isInstanceOf(ObjectStoreException.class);
}
@@ -117,7 +117,7 @@ public interface BucketBlobStoreContract {
BlobStore store = testee();
BlobId blobId = store.save(BucketName.DEFAULT, SHORT_BYTEARRAY, LOW_COST).block();
- assertThatThrownBy(() -> store.read(CUSTOM, blobId))
+ assertThatThrownBy(() -> store.read(CUSTOM, blobId).read())
.isInstanceOf(ObjectStoreException.class);
}
diff --git a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/DeleteBlobStoreContract.java b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/DeleteBlobStoreContract.java
index 616f355..b0cbeb9 100644
--- a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/DeleteBlobStoreContract.java
+++ b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/DeleteBlobStoreContract.java
@@ -65,7 +65,7 @@ public interface DeleteBlobStoreContract {
BlobId blobId = store.save(defaultBucketName, SHORT_BYTEARRAY, LOW_COST).block();
store.delete(defaultBucketName, blobId).block();
- assertThatThrownBy(() -> store.read(defaultBucketName, blobId))
+ assertThatThrownBy(() -> store.read(defaultBucketName, blobId).read())
.isInstanceOf(ObjectStoreException.class);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org