[GitHub] [geode] BalaKaza commented on a change in pull request #7513: GEODE-10121: Fix transactional redis commands

[GitBox <gi...@apache.org>]

BalaKaza commented on a change in pull request #7513:
URL: https://github.com/apache/geode/pull/7513#discussion_r838945305



##########
File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/string/MSetDUnitTest.java
##########
@@ -114,6 +119,33 @@ public void testMSet_concurrentInstancesHandleBucketMovement() {
                     .allSatisfy(value -> assertThat(value).startsWith("valueTwo"))));
   }
 
+  @Test
+  public void testMSet_isTransactional() {

Review comment:
       Because the reference for the RedisString is changing in the implementation. I was not able to get that exception being thrown that way after performing the MSET. That is why the check now makes sure it's not the same object reference after the mset happens. I am happy to know if there is any mechanism to get the exception thrown.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org