You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/20 18:46:23 UTC
[GitHub] [geode] demery-pivotal opened a new pull request #6708: GEODE-9441: Reduce Nested func test thread count
demery-pivotal opened a new pull request #6708:
URL: https://github.com/apache/geode/pull/6708
Change `NestedFunctionExecutionDistributedTest` to create fewer threads.
The test creates a number of threads that is a multiple of
`MAX_FE_THREADS`. On a CI machine, the default value of `MAX_FE_THREADS`
can be very high, causing this test to create thousands of threads. This
can leave the system unable to create threads for other processes, which
in turn can cause Gradle processes or other tests to fail or hang.
This test now sets `MAX_FE_THREADS` to a lower value (100), which
suffices for the purpose of the test, and results in greatly reduced
consumption of threads.
Co-authored-by: Dale Emery <de...@vmware.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] boglesby commented on a change in pull request #6708: GEODE-9441: Reduce Nested func test thread count
Posted by GitBox <gi...@apache.org>.
boglesby commented on a change in pull request #6708:
URL: https://github.com/apache/geode/pull/6708#discussion_r673489081
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/NestedFunctionExecutionDistributedTest.java
##########
@@ -111,6 +116,7 @@ private int createServerCache() throws IOException {
private void createClientCache(int port, int functionTimeout) {
System.setProperty(GEMFIRE_PREFIX + "CLIENT_FUNCTION_TIMEOUT", String.valueOf(functionTimeout));
+ System.setProperty(MAX_FE_THREADS_PROPERTY, TEST_MAX_FE_THREADS);
Review comment:
Its not necessary to set this value in the client. The Function Execution thread pool is not created there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] demery-pivotal merged pull request #6708: GEODE-9441: Reduce Nested func test thread count
Posted by GitBox <gi...@apache.org>.
demery-pivotal merged pull request #6708:
URL: https://github.com/apache/geode/pull/6708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] demery-pivotal commented on a change in pull request #6708: GEODE-9441: Reduce Nested func test thread count
Posted by GitBox <gi...@apache.org>.
demery-pivotal commented on a change in pull request #6708:
URL: https://github.com/apache/geode/pull/6708#discussion_r673495978
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/NestedFunctionExecutionDistributedTest.java
##########
@@ -111,6 +116,7 @@ private int createServerCache() throws IOException {
private void createClientCache(int port, int functionTimeout) {
System.setProperty(GEMFIRE_PREFIX + "CLIENT_FUNCTION_TIMEOUT", String.valueOf(functionTimeout));
+ System.setProperty(MAX_FE_THREADS_PROPERTY, TEST_MAX_FE_THREADS);
Review comment:
Currently the client does `MAX_FE_THREADS * 2` executions of `ParentFunction`. If I don't set `MAX_FE_THREADS` in the client, I get a swarm of failures with that many functions. Should I directly reduce the number of functions it executes, rather than computing from `MAX_FE_THREADS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] boglesby commented on a change in pull request #6708: GEODE-9441: Reduce Nested func test thread count
Posted by GitBox <gi...@apache.org>.
boglesby commented on a change in pull request #6708:
URL: https://github.com/apache/geode/pull/6708#discussion_r673540015
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/NestedFunctionExecutionDistributedTest.java
##########
@@ -111,6 +116,7 @@ private int createServerCache() throws IOException {
private void createClientCache(int port, int functionTimeout) {
System.setProperty(GEMFIRE_PREFIX + "CLIENT_FUNCTION_TIMEOUT", String.valueOf(functionTimeout));
+ System.setProperty(MAX_FE_THREADS_PROPERTY, TEST_MAX_FE_THREADS);
Review comment:
Sorry, you're right. You should set it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] demery-pivotal commented on a change in pull request #6708: GEODE-9441: Reduce Nested func test thread count
Posted by GitBox <gi...@apache.org>.
demery-pivotal commented on a change in pull request #6708:
URL: https://github.com/apache/geode/pull/6708#discussion_r673495978
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/NestedFunctionExecutionDistributedTest.java
##########
@@ -111,6 +116,7 @@ private int createServerCache() throws IOException {
private void createClientCache(int port, int functionTimeout) {
System.setProperty(GEMFIRE_PREFIX + "CLIENT_FUNCTION_TIMEOUT", String.valueOf(functionTimeout));
+ System.setProperty(MAX_FE_THREADS_PROPERTY, TEST_MAX_FE_THREADS);
Review comment:
Currently the client does `MAX_FE_THREADS * 2` executions of `ParentFunction`. If I don't set `MAX_FE_THREADS` in the client, I get a swarm of "Pool unexpected socket timed out on client connection" failures with that many functions. Should I directly reduce the number of functions it executes, rather than computing from `MAX_FE_THREADS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org