You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/18 17:55:51 UTC

[GitHub] [spark] mridulm commented on pull request #37885: [SPARK-40428][CORE][WIP] Fix shutdown hook in the CoarseGrainedSchedulerBackend

mridulm commented on PR #37885:
URL: https://github.com/apache/spark/pull/37885#issuecomment-1250356967

   Looks good to me - modulo @dongjoon-hyun's comment.
   We might want to also wrap `FallbackStorage.cleanUp` in `SparkContext.stop`. It is not strictly required for ensuring this specific codepath goes through, but will help ensure stop goes through completely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org