You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/01/04 00:14:14 UTC

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12154


Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................

[build-and-test] add short-circuiting for RUN_FLAKY_ONLY

Added a short circuit into build-and-test.sh: in case of
RUN_FLAKY_ONLY=1 and no flaky tests are reported, don't build
anything and report success right away.

Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 44 insertions(+), 49 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12154/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12154 )

Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@212
PS1, Line 212:     export KUDU_FLAKY_TEST_ATTEMPTS=1
> If I'm not mistaken, the code before this patch fetched the list of flaky t
Ah I misread the new code; this is an OR, not an AND. That's correct, then.



-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jan 2019 19:26:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12154

to look at the new patch set (#2).

Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................

[build-and-test] add short-circuiting for RUN_FLAKY_ONLY

Added a short circuit into build-and-test.sh: in case of
RUN_FLAKY_ONLY=1 and no flaky tests are reported, don't build
anything and report success right away.

Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 59 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12154/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12154 )

Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12154/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12154/1//COMMIT_MSG@10
PS1, Line 10: don't build
            : anything and report success right away.
The placement of the new code is such that we'll still run through the thirdparty build though; I thought you wanted to short-circuit that too?


http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@210
PS1, Line 210: just re-run those
Nit: "run just flaky tests"


http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@212
PS1, Line 212: if [ "$RUN_FLAKY_ONLY" == "1" -o "$KUDU_FLAKY_TEST_ATTEMPTS" -gt 1 ]; then
Don't we have to get the flaky test list regardless of whether RUN_FLAKY_ONLY is 1? That's what the old code did.



-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jan 2019 00:25:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12154

to look at the new patch set (#3).

Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................

[build-and-test] add short-circuiting for RUN_FLAKY_ONLY

Added a short circuit into build-and-test.sh: in case of
RUN_FLAKY_ONLY=1 and no flaky tests are reported, don't build
anything and report success right away.

Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 60 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12154/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12154 )

Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................

[build-and-test] add short-circuiting for RUN_FLAKY_ONLY

Added a short circuit into build-and-test.sh: in case of
RUN_FLAKY_ONLY=1 and no flaky tests are reported, don't build
anything and report success right away.

Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Reviewed-on: http://gerrit.cloudera.org:8080/12154
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 60 insertions(+), 65 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build-and-test] add short-circuiting for RUN FLAKY ONLY

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12154 )

Change subject: [build-and-test] add short-circuiting for RUN_FLAKY_ONLY
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12154/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12154/1//COMMIT_MSG@10
PS1, Line 10: don't build
            : anything and report success right away.
> The placement of the new code is such that we'll still run through the thir
Good catch!  Indeed: I noticed that as well, but for some reason I didn't move it yet.  Probably, I need to get some fresh air.


http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@210
PS1, Line 210: just re-run those
> Nit: "run just flaky tests"
Done


http://gerrit.cloudera.org:8080/#/c/12154/1/build-support/jenkins/build-and-test.sh@212
PS1, Line 212: if [ "$RUN_FLAKY_ONLY" == "1" -o "$KUDU_FLAKY_TEST_ATTEMPTS" -gt 1 ]; then
> Don't we have to get the flaky test list regardless of whether RUN_FLAKY_ON
If I'm not mistaken, the code before this patch fetched the list of flaky tests only if KUDU_FLAKY_TEST_ATTEMPTS > 1 or RUN_FLAKE_ONLY==1.

Do you mean it doesn't hurt to fetch the list unconditionally?



-- 
To view, visit http://gerrit.cloudera.org:8080/12154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69278c08c496749cd5f30e2d042b9291efde202c
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:23:26 +0000
Gerrit-HasComments: Yes