[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8900: chore: refactor, add typing and fix uncovered errors

[GitBox <gi...@apache.org>]

serenajiang commented on a change in pull request #8900: chore: refactor, add typing and fix uncovered errors
URL: https://github.com/apache/incubator-superset/pull/8900#discussion_r361876069
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -19,7 +19,7 @@
 import re
 from collections import OrderedDict
 from datetime import datetime
-from typing import Any, Dict, List, NamedTuple, Optional, Tuple, Union
+from typing import Any, Dict, Hashable, List, NamedTuple, Optional, Tuple, Union
 
 Review comment:
   Might have missed it, but are there any `Hashable`s that aren't `Dict`s?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org