You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Niels Bo (JIRA)" <ji...@apache.org> on 2008/02/29 22:44:51 UTC

[jira] Created: (WICKET-1388) "charset=UTF-8" is appended to Content-Type of DynamicWebResources

"charset=UTF-8" is appended to Content-Type of  DynamicWebResources
-------------------------------------------------------------------

                 Key: WICKET-1388
                 URL: https://issues.apache.org/jira/browse/WICKET-1388
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.1
         Environment: IE 6.0, Acrobat Reader 7.0.9
            Reporter: Niels Bo


After upgrading from wicket 1.2.6 to 1.3.1 we now have a big problem when opening PDF files inside the IE browser window. 
Instead the PDF file is now loaded as a separate window, leaving the Browser window empty.

I traced the problem down wicket always appending ";charset=UTF-8" to the Content-Type, and this can be viewed by using a http debugger:

Wicket 1.2.6: Works 
Content-Type: application/pdf 

Wicket 1.3.1: PDF opened outside the browser.
Content-Type: application/pdf; charset=UTF-8 

The ";charset=UTF-8" is appended in ResourceStreamRequestTarget, and I can't see a way to override it. 

Please make it possible to have the Content-Type as set by the DynamicWebResource

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1388) "charset=UTF-8" is appended to Content-Type of DynamicWebResources

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1388.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.2
         Assignee: Johan Compagner

this is weird, ResourceStreamRequestTarget does set that charset already long long time.
But there are other changes in that area.

i guess it only makes sense to append charset=XXX to the content type if the type is of type text so i changed the code to check first the content type

> "charset=UTF-8" is appended to Content-Type of  DynamicWebResources
> -------------------------------------------------------------------
>
>                 Key: WICKET-1388
>                 URL: https://issues.apache.org/jira/browse/WICKET-1388
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.1
>         Environment: IE 6.0, Acrobat Reader 7.0.9
>            Reporter: Niels Bo
>            Assignee: Johan Compagner
>             Fix For: 1.3.2
>
>
> After upgrading from wicket 1.2.6 to 1.3.1 we now have a big problem when opening PDF files inside the IE browser window. 
> Instead the PDF file is now loaded as a separate window, leaving the Browser window empty.
> I traced the problem down wicket always appending ";charset=UTF-8" to the Content-Type, and this can be viewed by using a http debugger:
> Wicket 1.2.6: Works 
> Content-Type: application/pdf 
> Wicket 1.3.1: PDF opened outside the browser.
> Content-Type: application/pdf; charset=UTF-8 
> The ";charset=UTF-8" is appended in ResourceStreamRequestTarget, and I can't see a way to override it. 
> Please make it possible to have the Content-Type as set by the DynamicWebResource

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.