You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/07 10:52:13 UTC
[GitHub] [flink] TanYuxin-tyx opened a new pull request, #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
TanYuxin-tyx opened a new pull request, #20200:
URL: https://github.com/apache/flink/pull/20200
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
To improve shuffle performance, more detailed fields should be added to `PartitionDescriptor`, for example, whether the partition is a broadcast partition or the distribution pattern of the intermediate result.
After the detailed information is added, the Shuffle Service can use different Shuffle strategies in different situations, which may lead to better shuffle performance.
In addition, we only add fields to `PartitionDescriptor`, which is compatible with the previous version, and the added fields are insensitive to earlier users.
## Brief change log
- *Add fields of `isBroadcast` and `distributionPattern` to `PartitionDescriptor`.*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is already covered by existing tests, such as *NettyShuffleUtilsTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a diff in pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
Posted by GitBox <gi...@apache.org>.
wsry commented on code in PR #20200:
URL: https://github.com/apache/flink/pull/20200#discussion_r920828843
##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java:
##########
@@ -53,14 +54,22 @@ public class PartitionDescriptor implements Serializable {
/** Connection index to identify this partition of intermediate result. */
private final int connectionIndex;
+ /** Whether the intermediate result is a broadcast result. */
+ private final boolean isBroadcast;
+
+ /** The distribution pattern of the intermediate result. */
+ private final DistributionPattern distributionPattern;
Review Comment:
I would suggest to use a boolean type instead of DistributionPattern to avoid exposing a the new internal type which is not public. Currently, this new information is never used in the NettyShuffleMaster, if someone modifies the DistributionPattern, for example, removing some enum fields, the compatibility will be broken and the person who modifies DistributionPattern will never realize that. I think we can use something like this to replace the current field:
```private final boolean isAllToAllDistribution;```
then we only rely on the all to all property and we convert the DistributionPattern to isAllToAllDistribution internally, if someone modifies the code, then he/she must also take care of the internal conversion logic. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
Posted by GitBox <gi...@apache.org>.
wsry commented on PR #20200:
URL: https://github.com/apache/flink/pull/20200#issuecomment-1190103039
@TanYuxin-tyx Thanks for the update. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on code in PR #20200:
URL: https://github.com/apache/flink/pull/20200#discussion_r922937503
##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java:
##########
@@ -53,14 +54,22 @@ public class PartitionDescriptor implements Serializable {
/** Connection index to identify this partition of intermediate result. */
private final int connectionIndex;
+ /** Whether the intermediate result is a broadcast result. */
+ private final boolean isBroadcast;
+
+ /** The distribution pattern of the intermediate result. */
+ private final DistributionPattern distributionPattern;
Review Comment:
@wsry Good point. Thanks for reviewing the code. I have updated the PR according to the comments, could you please take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on PR #20200:
URL: https://github.com/apache/flink/pull/20200#issuecomment-1186548326
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20200:
URL: https://github.com/apache/flink/pull/20200#issuecomment-1177408930
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88755aaf7f9375855176b5e606bcea612ae09f5f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88755aaf7f9375855176b5e606bcea612ae09f5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88755aaf7f9375855176b5e606bcea612ae09f5f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry closed pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
Posted by GitBox <gi...@apache.org>.
wsry closed pull request #20200: [FLINK-28446][runtime] Expose more information in PartitionDescriptor to support more optimized Shuffle Service
URL: https://github.com/apache/flink/pull/20200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org