You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/07/19 15:04:35 UTC
[GitHub] [camel] klease opened a new pull request, #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
klease opened a new pull request, #8015:
URL: https://github.com/apache/camel/pull/8015
When synchronizations are handed over, add a method to allow some housekeeping
to be performed. In the OnCompletionProcessor.OnCompletionSynchronizationAfterConsumer
this method stores the routeId on the Exchange.
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
klease commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1189172192
There is some analysis in the JIRA issue from Eduard and myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
klease commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1204060425
> Looking at the code I assume that all the completions will be executed when the SEDA pipelist gets completed. Is my assumption correct?
Yes, this is correct.
> I want to add here that in case "before consumer" mode is used, I'd expect the completions to be executed before the message gets processed in the next queue of the defined pipeline. Does the fix provide such behavior?
Unfortunately not. In fact, the current PR doesn't handle the before consumer mode at all. I can add this but unfortunately the completions are still called at the end of the entire pipeline. The change in the PR doesn't prevent the handover from occurring; it only ensures that when the handed-over completions execute, they will perform the logic for all the routes traveled by the exchange and not only the last one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1189225416
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
klease commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1204139924
I think https://github.com/apache/camel/pull/8105 will make the beforeConsumer mode work as expected by preventing the handover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Gems commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
Gems commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1203989560
Thank you for your effort, guys.
I'd like to understand the way the system is supposed to work after the fix.
Looking at the code I assume that all the completions will be executed when the SEDA pipelist gets completed. Is my assumption correct?
I want to add here that in case "before consumer" mode is used, I'd expect the completions to be executed before the message gets processed in the next queue of the defined pipeline. Does the fix provide such behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jeremyross commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
jeremyross commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1200483113
My tests for this issue are passing with this PR. Also did some regression testing with another decent size integration. All tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Gems commented on pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
Gems commented on PR #8015:
URL: https://github.com/apache/camel/pull/8015#issuecomment-1204067540
Thanks for elaboration.
I didn't quite get the following part: _"unfortunately the completions are still called at the end of the entire pipeline"_. Does it mean that it should be like that by design or there some other reasons?
I try to understand if my expectation on how it shoudl work with "before consumer" mode are correct and aligned with the design. If they are correct, then I guess, we should be able to find a way to get it work the corret way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease merged pull request #8015: CAMEL-18275: Address issue of completions not being run in SEDA pipeline
Posted by GitBox <gi...@apache.org>.
klease merged PR #8015:
URL: https://github.com/apache/camel/pull/8015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org