You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/03/31 22:23:41 UTC
[GitHub] couchdb-fauxton pull request: Gruntfile fix
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/350
Gruntfile fix
A recent commit assumes the template always has a certain structure;
this just adds a check to only set i18n for elements that exist.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton gruntfile-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #350
----
commit d0efcc7e48aaab5b0b6400fba9670332158e6b7b
Author: Ben Keen <be...@gmail.com>
Date: 2015-03-31T20:21:48Z
Gruntfile fix
Recent code assumes the template always has a certain structure;
this just adds a check to only set i18n for existing elements.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] couchdb-fauxton pull request: Gruntfile fix
Posted by Robert Kowalski <ro...@kowalski.gd>.
how about just iterating over the contents of `.template`?
On Tue, Mar 31, 2015 at 11:11 PM, michellephung <gi...@git.apache.org> wrote:
> Github user michellephung commented on the pull request:
>
>
> https://github.com/apache/couchdb-fauxton/pull/350#issuecomment-88251194
>
> +1
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] couchdb-fauxton pull request: Gruntfile fix
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/350#issuecomment-88251194
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Gruntfile fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Gruntfile fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/350#issuecomment-88493717
This is now moot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---