You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by jfrazee <gi...@git.apache.org> on 2016/03/31 17:37:29 UTC
[GitHub] nifi pull request: NIFI-1710 Resolve path name to nifi.sh in start...
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/315
NIFI-1710 Resolve path name to nifi.sh in start script
This adds `realpath` to nifi.sh to resolve location of nifi.sh when its symlinked (instead of installed using the `install` command). Recent versions of Linux and BSD make `realpath` available.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/nifi NIFI-1710
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit dbad7f41d6177f38f3736e539e77bb05433c2773
Author: Joey Frazee <jo...@icloud.com>
Date: 2016-03-31T15:33:29Z
Added realpath to nifi.sh to resolve its location when symlinked
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1710 Resolve path name to nifi.sh in start...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the pull request:
https://github.com/apache/nifi/pull/315#issuecomment-204017042
@arpitgupta Ok, yeah, older versions of coreutils don't have it. I was doing this with `readlink` but BSD readlink doesn't have the same options as GNU. Looks like it might be necessary to push this down into detectOS(), if people want this sort of change at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #315: NIFI-1710 Resolve path name to nifi.sh in start script
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/315
@jfrazee
could you rebase this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1710 Resolve path name to nifi.sh in start...
Posted by arpitgupta <gi...@git.apache.org>.
Github user arpitgupta commented on the pull request:
https://github.com/apache/nifi/pull/315#issuecomment-204001765
I cant find packages for centos 6 that will install this in the os repos, epel repos etc. Have not checked other OS's. I upgraded coreutils and still did not get this command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1710 Resolve path name to nifi.sh in start...
Posted by arpitgupta <gi...@git.apache.org>.
Github user arpitgupta commented on the pull request:
https://github.com/apache/nifi/pull/315#issuecomment-204061845
what about moving to python2.4 for these scripts. That way we get a unified file for linux and windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1710 Resolve path name to nifi.sh in start...
Posted by busbey <gi...@git.apache.org>.
Github user busbey commented on the pull request:
https://github.com/apache/nifi/pull/315#issuecomment-204066394
Please do not attempt to use python as a substitute for OS shell scripts. It's a path to ruin, the mechanics of properly managing things on Bash-having systems and Windows are fundamentally different (until we can just switch to bash-only for windows 10).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #315: NIFI-1710 Resolve path name to nifi.sh in start scri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---