You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/10/05 11:40:45 UTC

[GitHub] chetanmeh commented on a change in pull request #4048: Ensure that limits are set properly

chetanmeh commented on a change in pull request #4048: Ensure that limits are set properly
URL: https://github.com/apache/incubator-openwhisk/pull/4048#discussion_r222976600
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/database/LimitsCommandTests.scala
 ##########
 @@ -55,7 +55,7 @@ class LimitsCommandTests extends FlatSpec with WhiskAdminCliTestBase {
       ns) shouldBe CommandMessages.limitsSuccessfullySet(ns)
 
     val limits = limitsStore.get[LimitEntity](DocInfo(LimitsCommand.limitIdOf(EntityName(ns)))).futureValue
-    limits.limits shouldBe UserLimits(Some(3), Some(7), Some(11), Some(Set("nodejs:6", "blackbox")))
 
 Review comment:
   Cannot think of. Updated the test now to also include param name in method to make it explicit which value is for what

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services