You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/22 14:15:56 UTC
[GitHub] [solr] risdenk opened a new pull request #683: SOLR-14920: Add spotless commits to .git-blame-ignore-revs
risdenk opened a new pull request #683:
URL: https://github.com/apache/solr/pull/683
https://issues.apache.org/jira/browse/SOLR-14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #683: SOLR-14920: Add spotless commits to .git-blame-ignore-revs
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #683:
URL: https://github.com/apache/solr/pull/683#discussion_r811999676
##########
File path: .git-blame-ignore-revs
##########
@@ -9,3 +9,18 @@
# SOLR-14920 [google java formatter applied]
Review comment:
I don't see that commit on branch_9_0?
`git log --pretty=oneline | grep -F 8081b216e6e17f1827ff4d6102cb408c3c599cf`
^^^ returns nothing.
I think I covered the two JWT commits here:
```
➜ solr git:(ignore-spotless-blame-9_0) git log --pretty=oneline | grep -F 8a9e314c4d301f85c216b03b0062b3f070d50c47
8a9e314c4d301f85c216b03b0062b3f070d50c47 SOLR-15907 Apply spotless only on JWT classes (#616)
➜ solr git:(ignore-spotless-blame-9_0) git log --pretty=oneline | grep -F 7299cb079e710f5763b90c6c865c0681c5ecf6e1
7299cb079e710f5763b90c6c865c0681c5ecf6e1 SOLR-15907 Spotless
```
they are at the top of the list (line 12 and 13)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #683: SOLR-14920: Add spotless commits to .git-blame-ignore-revs
Posted by GitBox <gi...@apache.org>.
risdenk merged pull request #683:
URL: https://github.com/apache/solr/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #683: SOLR-14920: Add spotless commits to .git-blame-ignore-revs
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #683:
URL: https://github.com/apache/solr/pull/683#discussion_r811995848
##########
File path: .git-blame-ignore-revs
##########
@@ -9,3 +9,18 @@
# SOLR-14920 [google java formatter applied]
Review comment:
```suggestion
# SOLR-14920 [google java formatter applied]
8081b216e6e17f1827ff4d6102cb408c3c599cfe
```
This is for jwt-auth spotless on branch_9_0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #683: SOLR-14920: Add spotless commits to .git-blame-ignore-revs
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #683:
URL: https://github.com/apache/solr/pull/683#discussion_r812004450
##########
File path: .git-blame-ignore-revs
##########
@@ -9,3 +9,18 @@
# SOLR-14920 [google java formatter applied]
Review comment:
My bad, I filtered on branch_9x, your two SHAs are already correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #683: SOLR-14920: Add spotless commits to .git-blame-ignore-revs
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #683:
URL: https://github.com/apache/solr/pull/683#discussion_r812005758
##########
File path: .git-blame-ignore-revs
##########
@@ -9,3 +9,18 @@
# SOLR-14920 [google java formatter applied]
Review comment:
No worries @janhoy appreciate the extra set of eyes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org