You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/02/19 07:39:00 UTC
Re: [PR] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]
nastra commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1494119575
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -1181,7 +1170,7 @@ public synchronized void testDeleteWithSnapshotIsolation()
}
appendFiles.commit();
- sleep(10);
+ Awaitility.await().pollInterval(Duration.ofMillis(10)).until(() -> true);
Review Comment:
I don't think this makes a lot of sense to replace this sleep with Awaitility. I wonder whether this sleep here is even necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org