[GitHub] [spark] erikerlandson commented on a change in pull request #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

[GitBox <gi...@apache.org>]

erikerlandson commented on a change in pull request #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row
URL: https://github.com/apache/spark/pull/25024#discussion_r330809003
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/expressions/udaf.scala
 ##########
 @@ -165,3 +165,140 @@ abstract class MutableAggregationBuffer extends Row {
   /** Update the ith value of this buffer. */
   def update(i: Int, value: Any): Unit
 }
+
+/**
+ * The base class for implementing user-defined imperative aggregator (UDIA).
+ *
+ * @tparam A the aggregating type: implements the aggregation logic.
+ *
+ * @since 3.0.0
+ */
+@Experimental
+abstract class UserDefinedImperativeAggregator[A] extends Serializable {
 
 Review comment:
   After exploring what an enhancement to `Aggregator` looks like, my opinion is still that UDIA is a better replacement for UDAF.  Applying `Aggregator` in this way feels like hammering a square peg into a round hole.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org