You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wombatu-kun (via GitHub)" <gi...@apache.org> on 2026/06/12 05:07:04 UTC
[PR] Azure: Honor init-creation-stacktrace in ADLS input and output streams [iceberg]
wombatu-kun opened a new pull request, #16786:
URL: https://github.com/apache/iceberg/pull/16786
ADLSInputStream and ADLSOutputStream capture a full thread stack trace (Thread.currentThread().getStackTrace()) in their constructors. The stack is only used by finalize() to report the creation site when a stream is garbage collected without being closed, but the capture runs on every stream creation, i.e. on the per-file read/write path.
ResolvingFileIO already records the creation stack of the FileIO it delegates to, and tells the delegate to skip its own capture by setting init-creation-stacktrace=false in the delegate's properties. ADLSFileIO did not honor that flag, so every ADLS stream re-captured a stack trace even though ResolvingFileIO had already recorded one.
This makes the ADLS streams honor init-creation-stacktrace (default true), read through AzureProperties, exactly as #16739 does for the S3 input and output streams. The problem and the fix are identical to #16739; that PR contains the JMH benchmarks quantifying the per-stream allocation saved by skipping the capture. When the capture is disabled, finalize() still logs an unclosed-stream warning and points to the property to re-enable the creation stack.
Tests: TestAzureProperties covers the default, the explicit-disable value that ResolvingFileIO relies on, and that the setting survives serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Azure: Honor init-creation-stacktrace in ADLS input and output streams [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16786:
URL: https://github.com/apache/iceberg/pull/16786#issuecomment-5610715357
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Azure: Honor init-creation-stacktrace in ADLS input and output streams [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16786:
URL: https://github.com/apache/iceberg/pull/16786#issuecomment-5234611285
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Azure: Honor init-creation-stacktrace in ADLS input and output streams [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16786:
URL: https://github.com/apache/iceberg/pull/16786#issuecomment-6103788888
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org