[GitHub] [hadoop] virajith commented on a diff in pull request #4106: HADOOP-18172: Changed scope for isRootInternalDir/getRootFallbackLink for InodeTree

[GitBox <gi...@apache.org>]

virajith commented on code in PR #4106:
URL: https://github.com/apache/hadoop/pull/4106#discussion_r852455310


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -61,7 +61,7 @@
 
 @InterfaceAudience.Private

Review Comment:
   Public?



##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -458,11 +458,11 @@ private boolean hasFallbackLink() {
    * there will be root to root mapping. So, root does not represent as
    * internalDir.
    */
-  protected boolean isRootInternalDir() {
+  public boolean isRootInternalDir() {

Review Comment:
   Why limit to only these methods? Should the other package-private methods also be made public? why/why not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org