[jira] [Commented] (SLIDER-1039) Run slider-agent (py)tests from target directory not src directory

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLIDER-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073151#comment-15073151 ] 

ASF subversion and git services commented on SLIDER-1039:
---------------------------------------------------------

Commit d26e84520ceb750593557c60a4484c313d5351cc in incubator-slider's branch refs/heads/develop from [~elserj]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;h=d26e845 ]

SLIDER-1039 Run python tests from target directory

We shouldn't be running any python tests from the src
directory as this is for the clean copy of the code. This
should be done in the target directory. Uses the maven-resources-plugin
to copy the src and test python code into target and changes the
configuration on the exec plugin to specify the right paths
rooted in target.

Also removes some duplicative configuration when building on *nixes.

This does not address the glaring problem of slider-assembly
reaching into slider-agent directly to access python files.


> Run slider-agent (py)tests from target directory not src directory
> ------------------------------------------------------------------
>
>                 Key: SLIDER-1039
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1039
>             Project: Slider
>          Issue Type: Improvement
>          Components: build
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: Slider 0.91
>
>
> I had to -1 the slider-0.90.2-incubating RC0 build because I saw a bunch of pyc files in the source archive.
> Upon investigation on how these got there, it seems like the pytests that we run for the slider-agent module are invoked inside the src/ directory.
> We should really follow the same approach that is done for the Java files:
> * Compilation from src into target (just a copy for python)
> * Invocation of tests from inside target
> This should net us two things:
> * A build does not dirty the workspace (lots of ways this is good)
> * We can remove the {{*.pyc}} entry from {{.gitignore}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)