You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/10/23 17:38:38 UTC
Re: Review Request 71651: RANGER-2630: Ensure that entity deletes are
handled even when Atlas sets deleted entity's state as not ACTIVE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71651/
-----------------------------------------------------------
(Updated Oct. 23, 2019, 5:38 p.m.)
Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-2630: Ensure that entity deletes are handled even when Atlas sets deleted entity's state as not ACTIVE
Bugs: RANGER-2630
https://issues.apache.org/jira/browse/RANGER-2630
Repository: ranger
Description
-------
Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE.
Diffs (updated)
-----
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646
Diff: https://reviews.apache.org/r/71651/diff/4/
Changes: https://reviews.apache.org/r/71651/diff/3-4/
Testing (updated)
-------
Passes all unit tests
Thanks,
Abhay Kulkarni
Re: Review Request 71651: RANGER-2630: Ensure that entity deletes are
handled even when Atlas sets deleted entity's state as not ACTIVE
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71651/#review218376
-----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java
Line 120 (original), 121 (patched)
<https://reviews.apache.org/r/71651/#comment306079>
Please add "entityNotification.getIsEntityActive()" condition here as well - similar to #142:
ret = entityNotification.getIsEntityActive() && ! entityNotification.getIsEmptyClassifications();
It is possible for Atlas to send entity-create/entity-update notifications for deleted entities as well - during import operation.
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java
Line 128 (original), 129 (patched)
<https://reviews.apache.org/r/71651/#comment306080>
Comment for #121 applies for line #129 as well.
- Madhan Neethiraj
On Oct. 23, 2019, 9:53 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71651/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2019, 9:53 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2630
> https://issues.apache.org/jira/browse/RANGER-2630
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE.
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646
>
>
> Diff: https://reviews.apache.org/r/71651/diff/5/
>
>
> Testing
> -------
>
> Passes all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 71651: RANGER-2630: Ensure that entity deletes are
handled even when Atlas sets deleted entity's state as not ACTIVE
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71651/#review218378
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 23, 2019, 11:41 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71651/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2019, 11:41 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2630
> https://issues.apache.org/jira/browse/RANGER-2630
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE.
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646
>
>
> Diff: https://reviews.apache.org/r/71651/diff/6/
>
>
> Testing
> -------
>
> Passes all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 71651: RANGER-2630: Ensure that entity deletes are
handled even when Atlas sets deleted entity's state as not ACTIVE
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71651/
-----------------------------------------------------------
(Updated Oct. 23, 2019, 11:41 p.m.)
Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy.
Changes
-------
Addressed review comments
Bugs: RANGER-2630
https://issues.apache.org/jira/browse/RANGER-2630
Repository: ranger
Description
-------
Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE.
Diffs (updated)
-----
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646
Diff: https://reviews.apache.org/r/71651/diff/6/
Changes: https://reviews.apache.org/r/71651/diff/5-6/
Testing
-------
Passes all unit tests
Thanks,
Abhay Kulkarni
Re: Review Request 71651: RANGER-2630: Ensure that entity deletes are
handled even when Atlas sets deleted entity's state as not ACTIVE
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71651/
-----------------------------------------------------------
(Updated Oct. 23, 2019, 9:53 p.m.)
Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy.
Changes
-------
Addressed edge case due to disassociation of propagated tag from a deleted entity
Bugs: RANGER-2630
https://issues.apache.org/jira/browse/RANGER-2630
Repository: ranger
Description
-------
Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE.
Diffs (updated)
-----
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646
Diff: https://reviews.apache.org/r/71651/diff/5/
Changes: https://reviews.apache.org/r/71651/diff/4-5/
Testing
-------
Passes all unit tests
Thanks,
Abhay Kulkarni
Re: Review Request 71651: RANGER-2630: Ensure that entity deletes are
handled even when Atlas sets deleted entity's state as not ACTIVE
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71651/#review218363
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Oct. 23, 2019, 10:38 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71651/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2019, 10:38 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2630
> https://issues.apache.org/jira/browse/RANGER-2630
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE.
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646
>
>
> Diff: https://reviews.apache.org/r/71651/diff/4/
>
>
> Testing
> -------
>
> Passes all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>