You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hboutemy (via GitHub)" <gi...@apache.org> on 2025/03/04 16:54:54 UTC
[PR] import KEYS history from svn [maven-parent]
hboutemy opened a new pull request, #240:
URL: https://github.com/apache/maven-parent/pull/240
= https://svn.apache.org/repos/asf/maven/project/KEYS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #240:
URL: https://github.com/apache/maven-parent/pull/240#discussion_r1986029856
##########
KEYS:
##########
@@ -0,0 +1,4824 @@
+Edit this file in SVN at https://svn.apache.org/repos/asf/maven/project/KEYS
+
+Then publish to download area /dist/maven/KEYS by
+
+svn co https://dist.apache.org/repos/dist/release/maven dist-maven
+cd dist-maven
+svn cat https://svn.apache.org/repos/asf/maven/project/KEYS > KEYS
+
+then commit.
+Download area publication is a PMC activity. If you are not a PMC member
+then email private@maven.apache.org with a request to publish your
+modification.
Review Comment:
yes, I fully understand and respect (no fight against)
but TBH, when I am working on 10's of different aspects in parallel in many different Git repos (at ASF and others), it costs so much energy to open PRs here and there, wait, come back on PRs that I remember (eventually forget some), check
=> doing quickly a first commit then having other's feedback by improvement commits on top of the initial commit: this way of reviewing puts less stress and energy cost to me (and review comes in the form of improvements, which I find more positive)
on this one, I wanted a PR because I wanted RTC, but I see that I missed that I need to explain a little bit more my plan as it was not fully obvious that the plan is to migrate one step further from svn to Git
Sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #240:
URL: https://github.com/apache/maven-parent/pull/240#issuecomment-2698407997
How we will manage this file in this repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #240:
URL: https://github.com/apache/maven-parent/pull/240#discussion_r1984558048
##########
KEYS:
##########
@@ -0,0 +1,4824 @@
+Edit this file in SVN at https://svn.apache.org/repos/asf/maven/project/KEYS
+
+Then publish to download area /dist/maven/KEYS by
+
+svn co https://dist.apache.org/repos/dist/release/maven dist-maven
+cd dist-maven
+svn cat https://svn.apache.org/repos/asf/maven/project/KEYS > KEYS
+
+then commit.
+Download area publication is a PMC activity. If you are not a PMC member
+then email private@maven.apache.org with a request to publish your
+modification.
Review Comment:
this PR was about all the svn2git work to get the history (as stated in title)
but of course, updating instructions will be the next step (and I won't do a PR: this is a proof of CTR efficiency for basic updates)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #240:
URL: https://github.com/apache/maven-parent/pull/240#issuecomment-2698405954
What is purpose of it?
KEYS file used in distribution area https://downloads.apache.org/maven/KEYS
has source in https://dist.apache.org/repos/dist/release/maven/KEYS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #240:
URL: https://github.com/apache/maven-parent/pull/240#discussion_r1981932684
##########
KEYS:
##########
@@ -0,0 +1,4824 @@
+Edit this file in SVN at https://svn.apache.org/repos/asf/maven/project/KEYS
+
+Then publish to download area /dist/maven/KEYS by
+
+svn co https://dist.apache.org/repos/dist/release/maven dist-maven
+cd dist-maven
+svn cat https://svn.apache.org/repos/asf/maven/project/KEYS > KEYS
+
+then commit.
+Download area publication is a PMC activity. If you are not a PMC member
+then email private@maven.apache.org with a request to publish your
+modification.
Review Comment:
Should we update this instruction also in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #240:
URL: https://github.com/apache/maven-parent/pull/240#issuecomment-2701715565
> updating initially in Git instead of svn would ease committer work AND clarify the difference between original source for committers vs publication to dist
OK, so primary source will be here and after modification a PMC will copy / sync it do dist area - right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy merged PR #240:
URL: https://github.com/apache/maven-parent/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #240:
URL: https://github.com/apache/maven-parent/pull/240#issuecomment-2699010843
> has source in https://dist.apache.org/repos/dist/release/maven/KEYS
please take time to read the content: PMC writable only
updates to be done currently at https://svn.apache.org/repos/asf/maven/project/KEYS
then ask PMC to update dist
updating initially in Git instead of svn would ease committer work AND clarify the difference between original source for committers vs publication to dist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] import KEYS history from svn [maven-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #240:
URL: https://github.com/apache/maven-parent/pull/240#discussion_r1984705094
##########
KEYS:
##########
@@ -0,0 +1,4824 @@
+Edit this file in SVN at https://svn.apache.org/repos/asf/maven/project/KEYS
+
+Then publish to download area /dist/maven/KEYS by
+
+svn co https://dist.apache.org/repos/dist/release/maven dist-maven
+cd dist-maven
+svn cat https://svn.apache.org/repos/asf/maven/project/KEYS > KEYS
+
+then commit.
+Download area publication is a PMC activity. If you are not a PMC member
+then email private@maven.apache.org with a request to publish your
+modification.
Review Comment:
even with CRT and simple changes PR can be valuable 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org