You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/08 22:47:15 UTC

[GitHub] [beam] emilymye commented on a change in pull request #13508: Better logging for Python Docker environment

emilymye commented on a change in pull request #13508:
URL: https://github.com/apache/beam/pull/13508#discussion_r538865483



##########
File path: sdks/python/apache_beam/transforms/environments.py
##########
@@ -240,15 +240,16 @@ def __init__(
     super(DockerEnvironment, self).__init__(capabilities, artifacts)
     if container_image:
       logging.info(
-        'Using provided Python SDK container image: %s' % (container_image))
+          'Using provided Python SDK container image: %s' % (container_image))
       self.container_image = container_image
     else:
-      logging.info('No image given - inferring default Python SDK container image')
+      logging.info(
+          'No image given - inferring default Python SDK container image')

Review comment:
       hmm I'm not sure it's a good idea to link the possible env/runner flags to the log message here, but at least changed the wording a bit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org