[jira] [Commented] (KAFKA-1213) Adding fetcher needs to be avoided upon make-follower when replica manager is shutting down

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958866#comment-13958866 ] 

Jun Rao commented on KAFKA-1213:
--------------------------------

Is this really an issue? During the controlled shutdown, we first set isShuttingDown to false before sending the shutdown request to the controller. We won't add new fetchers for the LeaderAndIsr requests received during the controlled shutdown.

> Adding fetcher needs to be avoided upon make-follower when replica manager is shutting down
> -------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1213
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1213
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>             Fix For: 0.8.2
>
>
> Today in ReplicaManager.makeFollowers, we check if isShuttingDown.get() is false before adding fetchers. However this check cannot avoid adding fetcher while at the same time shutting down replica manager since the isShuttingDown can be set to false after the check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)