You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2024/02/22 18:36:39 UTC

(superset) branch validation-script-fix created (now 548379fb4d)

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a change to branch validation-script-fix
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 548379fb4d fix(releasing): fixes npm script for release validation

This branch includes the following new commits:

     new 548379fb4d fix(releasing): fixes npm script for release validation

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: fix(releasing): fixes npm script for release validation

Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch validation-script-fix
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 548379fb4d1d553bfe0e97afe8c163c5d00a2111
Author: Evan Rusackas <ev...@rusackas.com>
AuthorDate: Thu Feb 22 11:36:24 2024 -0700

    fix(releasing): fixes npm script for release validation
---
 RELEASING/validate_this_release.sh | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/RELEASING/validate_this_release.sh b/RELEASING/validate_this_release.sh
index 6d2b6fca5f..98c502be2a 100755
--- a/RELEASING/validate_this_release.sh
+++ b/RELEASING/validate_this_release.sh
@@ -39,7 +39,7 @@ PYTHON=$(get_python_command)
 PIP=$(get_pip_command)
 
 # Get the release directory's path. If you unzip an Apache release and just run the npm script to validate the release, this will be a file name like `apache-superset-x.x.xrcx-source.tar.gz`
-RELEASE_DIR_NAME="../../$(basename "$(dirname "$(pwd)")").tar.gz"
+RELEASE_ZIP_PATH="../../$(basename "$(dirname "$(pwd)")")-source.tar.gz"
 
 # Install dependencies from requirements.txt if the file exists
 if [ -f "path/to/requirements.txt" ]; then
@@ -47,8 +47,5 @@ if [ -f "path/to/requirements.txt" ]; then
     $PYTHON -m $PIP install -r path/to/requirements.txt
 fi
 
-# echo $PYTHON
-# echo $RELEASE_DIR_NAME
-
 # Run the Python script with the parent directory name as an argument
-$PYTHON ../RELEASING/verify_release.py "$RELEASE_DIR_NAME"
+$PYTHON ../RELEASING/verify_release.py "$RELEASE_ZIP_PATH"