You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/13 10:51:51 UTC
[GitHub] [flink] zentol commented on a diff in pull request #21501: [FLINK-30397][Connector/Pulsar] Remove Pulsar connector
zentol commented on code in PR #21501:
URL: https://github.com/apache/flink/pull/21501#discussion_r1046979593
##########
flink-docs/src/main/java/org/apache/flink/docs/util/ConfigurationOptionLocator.java:
##########
@@ -73,15 +73,6 @@ public class ConfigurationOptionLocator {
new OptionsClassLocation("flink-clients", "org.apache.flink.client.cli"),
new OptionsClassLocation(
"flink-table/flink-sql-client", "org.apache.flink.table.client.config"),
- new OptionsClassLocation(
- "flink-connectors/flink-connector-pulsar",
- "org.apache.flink.connector.pulsar.common.config"),
- new OptionsClassLocation(
- "flink-connectors/flink-connector-pulsar",
- "org.apache.flink.connector.pulsar.source"),
- new OptionsClassLocation(
- "flink-connectors/flink-connector-pulsar",
- "org.apache.flink.connector.pulsar.sink"),
Review Comment:
The associated generated files should be removed. The pulsar docs will have to provide equivalent files _somehow_.
(medium-term we need to make the config docs generator available to connector repos)
##########
tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java:
##########
@@ -210,11 +210,6 @@ private static int findNonBinaryFilesContainingText(
// dual-licensed under GPL 2 and EPL 2.0
// contained in sql-avro-confluent-registry
.filter(path -> !pathStartsWith(path, "/org/glassfish/jersey/internal"))
- // contained in sql-connector-pulsar
- .filter(
- path ->
- !pathStartsWith(
- path, "/org/apache/pulsar/shade/org/glassfish/jersey/"))
Review Comment:
We need to keep this for now, as otherwise CI will fail in the pulsar repo (eventually).
##########
mvnw:
##########
@@ -1,316 +0,0 @@
-#!/bin/sh
-# ----------------------------------------------------------------------------
-# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This shouldnt be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org