You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/12 21:18:27 UTC
[GitHub] [superset] eschutho commented on a change in pull request #13098: refactor: HighligthedSQL into functional component with Typescript
eschutho commented on a change in pull request #13098:
URL: https://github.com/apache/superset/pull/13098#discussion_r575524539
##########
File path: superset-frontend/src/SqlLab/components/HighlightedSql.tsx
##########
@@ -27,93 +26,91 @@ import ModalTrigger from '../../components/ModalTrigger';
SyntaxHighlighter.registerLanguage('sql', sql);
-const defaultProps = {
- maxWidth: 50,
- maxLines: 5,
- shrink: false,
-};
+interface propTypes {
Review comment:
this can become HighlightedSqlProps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org