You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/23 13:31:04 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11390: refactor: Replace react-bootstrap Modals with Antd in Datasource
codecov-io edited a comment on pull request #11390:
URL: https://github.com/apache/incubator-superset/pull/11390#issuecomment-715341582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=h1) Report
> Merging [#11390](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b86f779dc169b92d67bc52cd66614e919f1a0b07?el=desc) will **decrease** coverage by `4.03%`.
> The diff coverage is `75.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11390/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11390 +/- ##
==========================================
- Coverage 65.79% 61.75% -4.04%
==========================================
Files 838 858 +20
Lines 39903 40840 +937
Branches 3662 3687 +25
==========================================
- Hits 26254 25221 -1033
- Misses 13548 15438 +1890
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.94% <75.00%> (+0.26%)` | :arrow_up: |
| #python | `61.06% <ø> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `75.38% <63.33%> (+1.19%)` | :arrow_up: |
| [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/DeleteModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwudHN4) | `100.00% <100.00%> (ø)` | |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.00% <100.00%> (-24.00%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [233 more](https://codecov.io/gh/apache/incubator-superset/pull/11390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=footer). Last update [b86f779...2c0f359](https://codecov.io/gh/apache/incubator-superset/pull/11390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org