You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dsp <gi...@git.apache.org> on 2016/01/02 10:50:13 UTC
[GitHub] thrift pull request: THRIFT-3514: Add PHP 7 version of php_thrift_...
GitHub user dsp opened a pull request:
https://github.com/apache/thrift/pull/765
THRIFT-3514: Add PHP 7 version of php_thrift_protocol
This is an initial port of php_thrift_protocol to PHP7 and an RFC how to approach it.
However as we deal with zval's all over the place, we opt for separating
the C files completely leading to some overhead. However this
is a good start to see the differences in the implementation. From
there we should follow up with a more unified approach by refactoring
parts of the zval handling to be more generic so we can plug it
into PHP 7 and PHP 5 extensions.
Tested this by running with TestClient.php against a CPP server
and using TBinaryProtocolAccelerated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsp/thrift php7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #765
----
commit 51e10427629a5fe6bf28a3d44ffef4591b22a28b
Author: David Soria Parra <ds...@php.net>
Date: 2015-12-28T18:05:12Z
THRIFT-3514: Add PHP 7 version of php_thrift_protocol
This is an initial port of php_thrift_protocol to PHP7. However as
we deal with zval's all over the place, we opt for separating
the C files completely leading to some overhead. However this
is a good start to see the differences in the implementation. From
there we should follow up with a more unified approach by refactoring
parts of the zval handling to be more generic so we can plug it
into PHP 7 and PHP 5 extensions.
Tested this by running with TestClient.php against a CPP server
and using TBinaryProtocolAccelerated.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3514: Add PHP 7 version of php_thrift_...
Posted by stigsb <gi...@git.apache.org>.
Github user stigsb commented on the pull request:
https://github.com/apache/thrift/pull/765#issuecomment-169308828
Great work :8ball:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3514: Add PHP 7 version of php_thrift_...
Posted by ovr <gi...@git.apache.org>.
Github user ovr commented on the pull request:
https://github.com/apache/thrift/pull/765#issuecomment-168986427
Awesome!! :cake: :beers:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3514: Add PHP 7 version of php_thrift_...
Posted by dsp <gi...@git.apache.org>.
Github user dsp commented on the pull request:
https://github.com/apache/thrift/pull/765#issuecomment-169147175
The contbuild error seem to be in java-csharp and perl-py3 which are unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3514: Add PHP 7 version of php_thrift_...
Posted by dsp <gi...@git.apache.org>.
Github user dsp closed the pull request at:
https://github.com/apache/thrift/pull/765
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---