[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1075: HDDS-3369. Cleanup old write-path of volume in OM

[GitBox <gi...@apache.org>]

cxorm commented on a change in pull request #1075:
URL: https://github.com/apache/hadoop-ozone/pull/1075#discussion_r467757851



##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java
##########
@@ -82,15 +85,19 @@
    *         already the owner.
    * @throws IOException
    */
-  boolean setOwner(String volume, String owner) throws IOException;
+  default boolean setOwner(String volume, String owner) throws IOException {
+    throw new NotImplementedException("setOwner is not implemented");

Review comment:
       > In the long run I think we should split `OzoneManagerProtocol` interface into separate read and write interfaces. `OzoneManager` should only implement read interface, and `OzoneManagerProtocolClientSideTranslatorPB` should implement both.
   
   Thanks @adoroszlai for the thought.
   I'm fine with this proposal, and I would split the `OzoneManagerProtocol` interface into separate read and write interfaces in this patch. (Feel free to give me feedback or share your thoughts, thanks.)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org