You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/03 23:12:58 UTC

[GitHub] [incubator-gobblin] ibuenros commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command

ibuenros commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r280953068
 
 

 ##########
 File path: bin/gobblin.sh
 ##########
 @@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 Review comment:
   Can we leave `gobblin.sh` relatively simple and instead have `gobblin-cli.sh` and `gobblin-service.sh`? `gobblin.sh` would just redirect to the correct place depending on the first argument.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services