You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/11/22 13:39:37 UTC

[commons-statistics] 02/02: STATISTICS-48: Clarify test usage of isSupportConnected method

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 51720738d3452e7700496aa1a77a41556ef3f8c0
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Nov 22 13:38:43 2021 +0000

    STATISTICS-48: Clarify test usage of isSupportConnected method
---
 .../distribution/AbstractContinuousDistributionTest.java     | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
index a43395d..317f95b 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
@@ -95,6 +95,7 @@ class AbstractContinuousDistributionTest {
 
             @Override
             public boolean isSupportConnected() {
+                // This is deliberately false; the functionality is the subject of this test
                 return false;
             }
         };
@@ -200,6 +201,7 @@ class AbstractContinuousDistributionTest {
 
             @Override
             public boolean isSupportConnected() {
+                // This is deliberately false; the functionality is the subject of this test
                 return false;
             }
         };
@@ -278,11 +280,6 @@ class AbstractContinuousDistributionTest {
             public double getSupportUpperBound() {
                 return Double.POSITIVE_INFINITY;
             }
-
-            @Override
-            public boolean isSupportConnected() {
-                return true;
-            }
         };
         double x = distribution.inverseCumulativeProbability(0.5);
         // The value can be anything other than x0
@@ -355,11 +352,6 @@ class AbstractContinuousDistributionTest {
                 // Report upper bound incorrectly (it should be 10) to test cdf(1)
                 return Double.POSITIVE_INFINITY;
             }
-
-            @Override
-            public boolean isSupportConnected() {
-                return true;
-            }
         };
 
         // Accuracy is dependent on the tolerance of the solver