You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/11/26 14:08:33 UTC
Review Request 40748: Updated documentation to point out the need of a
resolvable hostname.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40748/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Lukas Loesche, and Timothy Chen.
Bugs: MESOS-3937
https://issues.apache.org/jira/browse/MESOS-3937
Repository: mesos
Description
-------
see summary.
Diffs
-----
docs/getting-started.md d120ad42d6e783048e6261750a9e7ad650d03669
Diff: https://reviews.apache.org/r/40748/diff/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 40748: Updated documentation to point out the need
of a resolvable hostname.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40748/#review120047
-----------------------------------------------------------
docs/getting-started.md (line 26)
<https://reviews.apache.org/r/40748/#comment181425>
It would also be great to print out a helpful diagnostic message when someone is running the tests (or the agent) and we don't find the right configuration needed for the docker containerizer to function correctly.
I just spent 15 minutes tracking down why the test was failing for me, and had to read through the lengthy conversation in [MESOS-3937](https://issues.apache.org/jira/browse/MESOS-3937) before seeing that I needed to adjust my hostname in vagrant, but a diagnostic message would have alerted me immediately to the issue.
- Ben Mahler
On Nov. 26, 2015, 1:08 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40748/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 1:08 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Lukas Loesche, and Timothy Chen.
>
>
> Bugs: MESOS-3937
> https://issues.apache.org/jira/browse/MESOS-3937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/getting-started.md d120ad42d6e783048e6261750a9e7ad650d03669
>
> Diff: https://reviews.apache.org/r/40748/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 40748: Updated documentation to point out the need
of a resolvable hostname.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40748/#review108122
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Nov. 26, 2015, 5:08 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40748/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 5:08 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Lukas Loesche, and Timothy Chen.
>
>
> Bugs: MESOS-3937
> https://issues.apache.org/jira/browse/MESOS-3937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/getting-started.md d120ad42d6e783048e6261750a9e7ad650d03669
>
> Diff: https://reviews.apache.org/r/40748/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 40748: Updated documentation to point out the need
of a resolvable hostname.
Posted by Lukas Loesche <lu...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40748/#review108124
-----------------------------------------------------------
Ship it!
Ship It!
- Lukas Loesche
On Nov. 26, 2015, 1:08 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40748/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 1:08 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Lukas Loesche, and Timothy Chen.
>
>
> Bugs: MESOS-3937
> https://issues.apache.org/jira/browse/MESOS-3937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/getting-started.md d120ad42d6e783048e6261750a9e7ad650d03669
>
> Diff: https://reviews.apache.org/r/40748/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>